mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibIPC: Break from message parsing if whole message payload is not ready
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Fixes the bug when we try to read message payload without checking if we
received enough bytes or file descriptors.
This commit is contained in:
Aliaksandr Kalenik 2025-04-07 18:22:04 +02:00 • committed by Alexander Kalenik
commit ac643aa392
Notes: github-actions[bot] 2025-04-07 18:26:57 +00:00
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibIPC/TransportSocket.cpp
View file

@ -152,9 +152,13 @@ TransportSocket::ShouldShutdown TransportSocket::read_as_many_messages_as_possib
} }
size_t index = 0; size_t index = 0;
while (index + sizeof(MessageHeader) < m_unprocessed_bytes.size()) { while (index + sizeof(MessageHeader) <= m_unprocessed_bytes.size()) {
MessageHeader header; MessageHeader header;
memcpy(&header, m_unprocessed_bytes.data() + index, sizeof(MessageHeader)); memcpy(&header, m_unprocessed_bytes.data() + index, sizeof(MessageHeader));
if (header.size + sizeof(MessageHeader) > m_unprocessed_bytes.size() - index)
break;
if (header.fd_count > m_unprocessed_fds.size())
break;
Message message; Message message;
for (size_t i = 0; i < header.fd_count; ++i) for (size_t i = 0; i < header.fd_count; ++i)
message.fds.append(m_unprocessed_fds.dequeue()); message.fds.append(m_unprocessed_fds.dequeue());

2
Libraries/LibIPC/UnprocessedFileDescriptors.h
View file

@ -27,6 +27,8 @@ public:
m_fds.prepend(move(fds)); m_fds.prepend(move(fds));
} }
size_t size() const { return m_fds.size(); }
private: private:
Vector<File> m_fds; Vector<File> m_fds;
}; };