mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 15:49:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Fix grammar in spec note for error checking serialization

Browse source 
See: 90720ff
This commit is contained in:
Shannon Booth 2025-01-17 14:41:32 +13:00 • committed by Andreas Kling
commit ac9670fb55
Notes: github-actions[bot] 2025-01-17 09:11:42 +00:00
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -245,8 +245,7 @@ WebIDL::ExceptionOr<NavigationResult> Navigation::navigate(String url, Navigatio
// 5. Let serializedState be StructuredSerializeForStorage(state). // 5. Let serializedState be StructuredSerializeForStorage(state).
// If this throws an exception, then return an early error result for that exception. // If this throws an exception, then return an early error result for that exception.
// FIXME: Fix this spec grammaro in the note // Spec-Note: It is important to perform this step early, since serialization can invoke web developer code,
// NOTE: It is importantly to perform this step early, since serialization can invoke web developer code,
// which in turn might change various things we check in later steps. // which in turn might change various things we check in later steps.
auto serialized_state_or_error = structured_serialize_for_storage(vm, state); auto serialized_state_or_error = structured_serialize_for_storage(vm, state);
if (serialized_state_or_error.is_error()) { if (serialized_state_or_error.is_error()) {
@ -309,7 +308,7 @@ WebIDL::ExceptionOr<NavigationResult> Navigation::reload(NavigationReloadOptions
// 3. If options["state"] exists, then set serializedState to StructuredSerializeForStorage(options["state"]). // 3. If options["state"] exists, then set serializedState to StructuredSerializeForStorage(options["state"]).
// If this throws an exception, then return an early error result for that exception. // If this throws an exception, then return an early error result for that exception.
// NOTE: It is importantly to perform this step early, since serialization can invoke web developer // Spec-Note: It is important to perform this step early, since serialization can invoke web developer
// code, which in turn might change various things we check in later steps. // code, which in turn might change various things we check in later steps.
if (options.state.has_value()) { if (options.state.has_value()) {
auto serialized_state_or_error = structured_serialize_for_storage(vm, options.state.value()); auto serialized_state_or_error = structured_serialize_for_storage(vm, options.state.value());