mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Add Array.prototype.join()

Browse source 
And share the code with Array.prototype.toString() :^)
This commit is contained in:
Andreas Kling 2020-04-15 10:06:01 +02:00
parent fa30355194
commit ad2aac5fde
Notes: sideshowbarker 2024-07-19 07:35:18 +09:00
3 changed files with 41 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -47,6 +47,7 @@ ArrayPrototype::ArrayPrototype()
put_native_function("shift", shift, 0);
put_native_function("toString", to_string, 0);
put_native_function("unshift", unshift, 1);
put_native_function("join", join, 1);
put("length", Value(0));
}
@ -194,20 +195,38 @@ Value ArrayPrototype::shift(Interpreter& interpreter)
return array->elements().take_first();
}
static Value join_array_with_separator(Interpreter& interpreter, const Array& array, StringView separator)
{
StringBuilder builder;
for (size_t i = 0; i < array.elements().size(); ++i) {
if (i != 0)
builder.append(separator);
if (!array.elements()[i].is_empty())
builder.append(array.elements()[i].to_string());
}
return js_string(interpreter, builder.to_string());
}
Value ArrayPrototype::to_string(Interpreter& interpreter)
{
auto* array = array_from(interpreter);
if (!array)
return {};
StringBuilder builder;
for (size_t i = 0; i < array->elements().size(); ++i) {
if (i != 0)
builder.append(',');
if (!array->elements()[i].is_empty())
builder.append(array->elements()[i].to_string());
}
return js_string(interpreter, builder.to_string());
return join_array_with_separator(interpreter, *array, ",");
}
Value ArrayPrototype::join(Interpreter& interpreter)
{
auto* array = array_from(interpreter);
if (!array)
return {};
String separator = ",";
if (interpreter.argument_count() == 1)
separator = interpreter.argument(0).to_string();
return join_array_with_separator(interpreter, *array, separator);
}
}

1
Libraries/LibJS/Runtime/ArrayPrototype.h
View file

@ -47,6 +47,7 @@ private:
static Value shift(Interpreter&);
static Value to_string(Interpreter&);
static Value unshift(Interpreter&);
static Value join(Interpreter&);
};
}

13
Libraries/LibJS/Tests/Array.prototype.join.js Normal file
View file

@ -0,0 +1,13 @@
load("test-common.js");
try {
assert(Array.prototype.push.length === 1);
assert(["hello", "friends"].join() === "hello,friends");
assert(["hello", "friends"].join(" ") === "hello friends");
assert(Array(3).join() === ",,");
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}