mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 07:41:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

headless-browser: Add an option to log per-test durations

Browse source 
This adds a verbosity option to log the start and end of each test, with
the duration taken for the test. To be able to use this option with our
exisiting verbosity flag, without cluttering stdout with other data, we
add verbosity levels to headless-browser. The level is increased by
providing the -v flag on the command line multiple times.
This commit is contained in:
Timothy Flynn 2024-11-30 08:51:59 -05:00 • committed by Tim Flynn
commit ad5de9d4e5
Notes: github-actions[bot] 2024-11-30 17:11:18 +00:00
4 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
UI/Headless/Test.cpp
View file

@ -443,7 +443,8 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize
size_t skipped_count = 0;
bool all_tests_ok = true;
bool is_tty = isatty(STDOUT_FILENO);
// Keep clearing and reusing the same line if stdout is a TTY.
bool log_on_one_line = app.verbosity < Application::VERBOSITY_LEVEL_LOG_TEST_DURATION && isatty(STDOUT_FILENO) == 1;
outln("Running {} tests...", tests.size());
auto all_tests_complete = Core::Promise<Empty>::construct();
@ -462,19 +463,15 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize
auto& test = tests[index];
test.start_time = UnixDateTime::now();
test.index = index + 1;
if (is_tty) {
// Keep clearing and reusing the same line if stdout is a TTY.
out("\33[2K\r");
if (log_on_one_line) {
out("\33[2K\r{}/{}: {}", test.index, tests.size(), test.relative_path);
(void)fflush(stdout);
} else {
outln("{}/{}: Start {}", test.index, tests.size(), test.relative_path);
}
out("{}/{}: {}", index + 1, tests.size(), test.relative_path);
if (is_tty)
fflush(stdout);
else
outln("");
Core::deferred_invoke([&]() mutable {
if (s_skipped_tests.contains_slow(test.input_path))
view.on_test_complete({ test, TestResult::Skipped });
@ -486,6 +483,11 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize
view.test_promise().when_resolved([&, run_next_test](auto result) {
result.test.end_time = UnixDateTime::now();
if (app.verbosity >= Application::VERBOSITY_LEVEL_LOG_TEST_DURATION) {
auto duration = result.test.end_time - result.test.start_time;
outln("{}/{}: Finish {}: {}ms", result.test.index, tests.size(), result.test.relative_path, duration.to_milliseconds());
}
switch (result.result) {
case TestResult::Pass:
++pass_count;
@ -523,7 +525,7 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize
MUST(all_tests_complete->await());
if (is_tty)
if (log_on_one_line)
outln("\33[2K\rDone!");
outln("==========================================================");
@ -531,13 +533,13 @@ ErrorOr<void> run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize
outln("==========================================================");
for (auto const& non_passing_test : non_passing_tests) {
if (non_passing_test.result == TestResult::Skipped && !app.verbose)
if (non_passing_test.result == TestResult::Skipped && app.verbosity < Application::VERBOSITY_LEVEL_LOG_SKIPPED_TESTS)
continue;
outln("{}: {}", test_result_to_string(non_passing_test.result), non_passing_test.test.relative_path);
}
if (app.verbose) {
if (app.verbosity >= Application::VERBOSITY_LEVEL_LOG_SLOWEST_TESTS) {
auto tests_to_print = min(10uz, tests.size());
outln("\nSlowest {} tests:", tests_to_print);