mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 20:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Ensure size constraints apply to non-BFC-root abspos boxes

Browse source 
BFC roots behave differently in that their height is computed twice,
before and after inside layout, since automatic height depends on the
results of inside layout. Other formatting contexts only require the
"before" pass, and so we can treat their content sizes as definite
before proceeding with inside layout.

This makes https://play.tailwind.com/ look beautiful. :^)
This commit is contained in:
Andreas Kling 2025-01-30 16:24:27 +01:00 • committed by Andreas Kling
parent bf34b63439
commit ad9d9bb684
Notes: github-actions[bot] 2025-01-30 18:34:08 +00:00
3 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -1245,6 +1245,15 @@ void FormattingContext::layout_absolutely_positioned_element(Box const& box, Ava
box_state.set_has_definite_height(true);
}
// NOTE: BFC is special, as their abspos auto height depends on performing inside layout.
// For other formatting contexts, the height we've resolved early is good.
// See FormattingContext::compute_auto_height_for_absolutely_positioned_element()
// for the special-casing of BFC roots.
if (!creates_block_formatting_context(box)) {
box_state.set_has_definite_width(true);
box_state.set_has_definite_height(true);
}
auto independent_formatting_context = layout_inside(box, LayoutMode::Normal, box_state.available_inner_space_or_constraints_from(available_space));
compute_height_for_absolutely_positioned_element(box, available_space, BeforeOrAfterInsideLayout::After);

13
Tests/LibWeb/Layout/expected/abspos-non-bfc-root-with-min-height-constraint.txt Normal file
View file

@ -0,0 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x0 [BFC] children: not-inline
Box <body> at (8,8) content-size 31.15625x300 positioned flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (8,8) content-size 31.15625x300 flex-item [BFC] children: inline
frag 0 from TextNode start: 0, length: 3, rect: [8,8 31.15625x17] baseline: 13.296875
"Sup"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x0]
PaintableBox (Box<BODY>) [8,8 31.15625x300]
PaintableWithLines (BlockContainer<DIV>) [8,8 31.15625x300]
TextPaintable (TextNode<#text>)

8
Tests/LibWeb/Layout/input/abspos-non-bfc-root-with-min-height-constraint.html Normal file
View file

@ -0,0 +1,8 @@
<!doctype html><style>
* { outline: 1px solid black; }
body {
position: absolute;
min-height: 50%;
display: flex;
}
</style><body><div>Sup