mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-27 12:46:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

headless-browser: Allow popups for LibWeb testing

Browse source
This commit is contained in:
Timothy Flynn 2024-10-05 17:26:49 -04:00 • committed by Tim Ledbetter
commit ae130822a0
Notes: github-actions[bot] 2024-10-06 00:43:26 +00:00
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Utilities/headless-browser.cpp
View file

@ -76,6 +76,9 @@ public:
view->client().async_set_viewport_size(0, view->m_viewport_size.to_type<Web::DevicePixels>()); view->client().async_set_viewport_size(0, view->m_viewport_size.to_type<Web::DevicePixels>());
view->client().async_set_window_size(0, window_size.to_type<Web::DevicePixels>()); view->client().async_set_window_size(0, window_size.to_type<Web::DevicePixels>());
if (WebView::Application::chrome_options().allow_popups == WebView::AllowPopups::Yes)
view->client().async_debug_request(0, "block-pop-ups"sv, "off"sv);
if (auto web_driver_ipc_path = WebView::Application::chrome_options().webdriver_content_ipc_path; web_driver_ipc_path.has_value()) if (auto web_driver_ipc_path = WebView::Application::chrome_options().webdriver_content_ipc_path; web_driver_ipc_path.has_value())
view->client().async_connect_to_webdriver(0, *web_driver_ipc_path); view->client().async_connect_to_webdriver(0, *web_driver_ipc_path);
@ -616,13 +619,18 @@ struct Application : public WebView::Application {
args_parser.add_option(rebaseline, "Rebaseline any executed layout or text tests", "rebaseline"); args_parser.add_option(rebaseline, "Rebaseline any executed layout or text tests", "rebaseline");
} }
virtual void create_platform_options(WebView::ChromeOptions&, WebView::WebContentOptions& web_content_options) override virtual void create_platform_options(WebView::ChromeOptions& chrome_options, WebView::WebContentOptions& web_content_options) override
{ {
if (!test_root_path.is_empty()) { if (!test_root_path.is_empty()) {
// --run-tests implies --layout-test-mode. // --run-tests implies --layout-test-mode.
is_layout_test_mode = true; is_layout_test_mode = true;
} }
if (is_layout_test_mode) {
// Allow window.open() to succeed for tests.
chrome_options.allow_popups = WebView::AllowPopups::Yes;
}
web_content_options.is_layout_test_mode = is_layout_test_mode ? WebView::IsLayoutTestMode::Yes : WebView::IsLayoutTestMode::No; web_content_options.is_layout_test_mode = is_layout_test_mode ? WebView::IsLayoutTestMode::Yes : WebView::IsLayoutTestMode::No;
} }