mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-12 04:22:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Meta: Add note about writing commit subjects in the imperative mood

Browse source
This commit is contained in:
Andreas Kling 2021-05-14 16:45:27 +02:00
commit aea709de31
Notes: sideshowbarker 2024-07-18 18:09:51 +09:00
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CONTRIBUTING.md
View file

@ -46,7 +46,8 @@ Nobody is perfect, and sometimes we mess things up. That said, here are some goo
* Split your changes into separate, atomic commits. * Split your changes into separate, atomic commits.
* Make sure your commits are rebased on the master branch. * Make sure your commits are rebased on the master branch.
* Wrap your commit messages at 72 characters. * Wrap your commit messages at 72 characters.
* The first line of the commit message should have the format "Category: Brief description of what's being changed". The "category" can be a subdirectory, but also something like "POSIX compliance" or "ClassName". Whatever seems logical. * The first line of the commit message is the subject line, and should have the format "Category: Brief description of what's being changed". The "category" can be a subdirectory, but also something like "POSIX compliance" or "ClassName". Whatever seems logical.
* Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work")
* Write your commit messages in proper English, with care and punctuation. * Write your commit messages in proper English, with care and punctuation.
* Squash your commits when making revisions after a patch review. * Squash your commits when making revisions after a patch review.
* Add your personal copyright line to files when making substantive changes. (Optional but encouraged!) * Add your personal copyright line to files when making substantive changes. (Optional but encouraged!)