mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Store the style sheet's source text on the CSSStyleSheet

Browse source 
This is to enable the inspector to show this source.

There's a fairly hefty FIXME here because duplicating the source text is
a significant waste of memory. But I don't want to get too sidetracked.
This commit is contained in:
Sam Atkins 2024-08-22 17:23:54 +01:00 • committed by Sam Atkins
commit b00137df38
Notes: github-actions[bot] 2024-09-03 09:13:23 +00:00
3 changed files with 22 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.cpp
View file

@ -371,4 +371,14 @@ void CSSStyleSheet::recalculate_namespaces()
}
}
void CSSStyleSheet::set_source_text(String source)
{
m_source_text = move(source);
}
Optional<String> CSSStyleSheet::source_text(Badge<DOM::Document>) const
{
return m_source_text;
}
}

5
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h
View file

@ -78,6 +78,9 @@ public:
bool disallow_modification() const { return m_disallow_modification; }
void set_source_text(String);
Optional<String> source_text(Badge<DOM::Document>) const;
private:
CSSStyleSheet(JS::Realm&, CSSRuleList&, MediaList&, Optional<URL::URL> location);
@ -89,6 +92,8 @@ private:
void set_constructed(bool constructed) { m_constructed = constructed; }
void set_disallow_modification(bool disallow_modification) { m_disallow_modification = disallow_modification; }
Optional<String> m_source_text;
JS::GCPtr<CSSRuleList> m_rules;
JS::GCPtr<CSSNamespaceRule> m_default_namespace_rule;
HashMap<FlyString, JS::GCPtr<CSSNamespaceRule>> m_namespace_rules;

9
Userland/Libraries/LibWeb/CSS/Parser/Helpers.cpp
View file

@ -20,9 +20,14 @@ CSS::CSSStyleSheet* parse_css_stylesheet(CSS::Parser::ParsingContext const& cont
if (css.is_empty()) {
auto rule_list = CSS::CSSRuleList::create_empty(context.realm());
auto media_list = CSS::MediaList::create(context.realm(), {});
return CSS::CSSStyleSheet::create(context.realm(), rule_list, media_list, location);
auto style_sheet = CSS::CSSStyleSheet::create(context.realm(), rule_list, media_list, location);
style_sheet->set_source_text({});
return style_sheet;
}
return CSS::Parser::Parser::create(context, css).parse_as_css_stylesheet(location);
auto* style_sheet = CSS::Parser::Parser::create(context, css).parse_as_css_stylesheet(location);
// FIXME: Avoid this copy
style_sheet->set_source_text(MUST(String::from_utf8(css)));
return style_sheet;
}
CSS::ElementInlineCSSStyleDeclaration* parse_css_style_attribute(CSS::Parser::ParsingContext const& context, StringView css, DOM::Element& element)