mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Demote VERIFYs in Completion() to ASSERT

Browse source 
These were *extremely* hot in profiles (noticed when looking at
disassembly).

Now that we've made the special empty JS::Value much harder to create
accidentally, we can feel better about turning these into ASSERT and
catching them in debug builds.
This commit is contained in:
Andreas Kling 2025-04-04 23:23:39 +02:00 • committed by Andreas Kling
commit b05b9378ed
Notes: github-actions[bot] 2025-04-05 09:21:22 +00:00
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Completion.h
View file

@ -64,8 +64,8 @@ public:
: m_type(type)
, m_value(value)
{
VERIFY(type != Type::Empty);
VERIFY(!value.is_special_empty_value());
ASSERT(type != Type::Empty);
ASSERT(!value.is_special_empty_value());
}
Completion(ThrowCompletionOr<Value> const&);