From b068dd732d0eb3613d9c5349125eb490caaad80d Mon Sep 17 00:00:00 2001 From: devgianlu Date: Mon, 2 Jun 2025 12:11:10 +0200 Subject: [PATCH] LibWeb/Crypto: Remove RSA-PSS key import FIXMEs after spec fix --- Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp b/Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp index f0e026abc7b..02ad99feffe 100644 --- a/Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp +++ b/Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp @@ -1564,12 +1564,10 @@ WebIDL::ExceptionOr> RSAPSS::import_key(AlgorithmParams const if (!meets_requirements) return WebIDL::DataError::create(m_realm, "Invalid JWK private key"_string); - // FIXME: Spec error, it should say 'the RSA private key identified by interpreting jwk according to section 6.3.2' - // 2. Let privateKey represent the RSA public key identified by interpreting jwk according to Section 6.3.1 of JSON Web Algorithms [JWA]. + // 2. Let privateKey represent the RSA private key identified by interpreting jwk according to Section 6.3.2 of JSON Web Algorithms [JWA]. auto private_key = TRY(parse_jwk_rsa_private_key(realm, jwk)); - // FIXME: Spec error, it should say 'not to be a valid RSA private key' - // 3. If privateKey can be determined to not be a valid RSA public key according to [RFC3447], then throw a DataError. + // 3. If privateKey can be determined to not be a valid RSA private key according to [RFC3447], then throw a DataError. auto maybe_valid = private_key.is_valid(); if (maybe_valid.is_error()) return WebIDL::DataError::create(m_realm, "Failed to verify key"_string);