From b10c87d31e4ab7534b7d6c6db36fab99d7de22eb Mon Sep 17 00:00:00 2001 From: Daniel Date: Tue, 20 Jun 2023 01:05:04 -0400 Subject: [PATCH] LibAudio: Remove redundant checks in WavLoader - Max size of a wav is u32::MAX, so file/data size will never be larger --- Userland/Libraries/LibAudio/WavLoader.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Userland/Libraries/LibAudio/WavLoader.cpp b/Userland/Libraries/LibAudio/WavLoader.cpp index 66b1de26c89..e337b72aef0 100644 --- a/Userland/Libraries/LibAudio/WavLoader.cpp +++ b/Userland/Libraries/LibAudio/WavLoader.cpp @@ -18,8 +18,6 @@ namespace Audio { -static constexpr size_t const maximum_wav_size = 1 * GiB; // FIXME: is there a more appropriate size limit? - WavLoaderPlugin::WavLoaderPlugin(NonnullOwnPtr stream) : LoaderPlugin(move(stream)) { @@ -194,8 +192,7 @@ MaybeLoaderError WavLoaderPlugin::parse_header() auto riff = TRY(m_stream->read_value()); CHECK(riff == RIFF::riff_magic, LoaderError::Category::Format, "RIFF header magic invalid"); - u32 size = TRY(m_stream->read_value>()); - CHECK(size < maximum_wav_size, LoaderError::Category::Format, "File size too large"); + TRY(m_stream->read_value>()); // File size header auto wave = TRY(m_stream->read_value()); CHECK(wave == RIFF::wave_subformat_id, LoaderError::Category::Format, "WAVE subformat id invalid"); @@ -292,7 +289,6 @@ MaybeLoaderError WavLoaderPlugin::parse_header() u32 data_size = TRY(m_stream->read_value>()); CHECK(found_data, LoaderError::Category::Format, "Found no data chunk"); - CHECK(data_size < maximum_wav_size, LoaderError::Category::Format, "Data too large"); m_total_samples = data_size / block_size_bytes;