mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-17 06:52:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Avoid FlyString->String->FlyString roundtrips in CSS variables

Browse source
This commit is contained in:
Andreas Kling 2024-03-16 07:48:17 +01:00
commit b15316eba8
Notes: sideshowbarker 2024-07-17 00:47:29 +09:00
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -6943,7 +6943,7 @@ NonnullRefPtr<StyleValue> Parser::resolve_unresolved_style_value(Badge<StyleComp
class PropertyDependencyNode : public RefCounted<PropertyDependencyNode> { class PropertyDependencyNode : public RefCounted<PropertyDependencyNode> {
public: public:
static NonnullRefPtr<PropertyDependencyNode> create(String name) static NonnullRefPtr<PropertyDependencyNode> create(FlyString name)
{ {
return adopt_ref(*new PropertyDependencyNode(move(name))); return adopt_ref(*new PropertyDependencyNode(move(name)));
} }
@ -6974,12 +6974,12 @@ public:
} }
private: private:
explicit PropertyDependencyNode(String name) explicit PropertyDependencyNode(FlyString name)
: m_name(move(name)) : m_name(move(name))
{ {
} }
String m_name; FlyString m_name;
Vector<NonnullRefPtr<PropertyDependencyNode>> m_children; Vector<NonnullRefPtr<PropertyDependencyNode>> m_children;
bool m_marked { false }; bool m_marked { false };
}; };
@ -7008,12 +7008,12 @@ NonnullRefPtr<StyleValue> Parser::resolve_unresolved_style_value(DOM::Element& e
static RefPtr<StyleValue const> get_custom_property(DOM::Element const& element, Optional<CSS::Selector::PseudoElement::Type> pseudo_element, FlyString const& custom_property_name) static RefPtr<StyleValue const> get_custom_property(DOM::Element const& element, Optional<CSS::Selector::PseudoElement::Type> pseudo_element, FlyString const& custom_property_name)
{ {
if (pseudo_element.has_value()) { if (pseudo_element.has_value()) {
if (auto it = element.custom_properties(pseudo_element).find(custom_property_name.to_string()); it != element.custom_properties(pseudo_element).end()) if (auto it = element.custom_properties(pseudo_element).find(custom_property_name); it != element.custom_properties(pseudo_element).end())
return it->value.value; return it->value.value;
} }
for (auto const* current_element = &element; current_element; current_element = current_element->parent_element()) { for (auto const* current_element = &element; current_element; current_element = current_element->parent_element()) {
if (auto it = current_element->custom_properties({}).find(custom_property_name.to_string()); it != current_element->custom_properties({}).end()) if (auto it = current_element->custom_properties({}).find(custom_property_name); it != current_element->custom_properties({}).end())
return it->value.value; return it->value.value;
} }
return nullptr; return nullptr;
@ -7029,10 +7029,10 @@ bool Parser::expand_variables(DOM::Element& element, Optional<Selector::PseudoEl
return false; return false;
} }
auto get_dependency_node = [&](FlyString name) -> NonnullRefPtr<PropertyDependencyNode> { auto get_dependency_node = [&](FlyString const& name) -> NonnullRefPtr<PropertyDependencyNode> {
if (auto existing = dependencies.get(name); existing.has_value()) if (auto existing = dependencies.get(name); existing.has_value())
return *existing.value(); return *existing.value();
auto new_node = PropertyDependencyNode::create(name.to_string()); auto new_node = PropertyDependencyNode::create(name);
dependencies.set(name, new_node); dependencies.set(name, new_node);
return new_node; return new_node;
}; };