mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-07 11:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Include the Content-Type boundary directive in form submissions

Browse source 
The spec requires that "multipart/form-data" Content-Type headers also
include a boundary directive. This allows the content server to validate
the submitted form data.

Google Lens, for example, rejects forms missing this directive.
This commit is contained in:
Timothy Flynn 2024-08-21 15:18:28 -04:00 • committed by Andreas Kling
parent 1cdccf901b
commit b16b9709b9
Notes: github-actions[bot] 2024-08-22 12:22:09 +00:00
3 changed files with 27 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp
View file

@ -747,6 +747,7 @@ ErrorOr<void> HTMLFormElement::submit_as_entity_body(URL::URL parsed_action, Vec
// 1. Assert: method is POST.
POSTResource::RequestContentType mime_type {};
Vector<POSTResource::Directive> mime_type_directives;
ByteBuffer body;
// 2. Switch on enctype:
@ -775,6 +776,7 @@ ErrorOr<void> HTMLFormElement::submit_as_entity_body(URL::URL parsed_action, Vec
// 2. Let mimeType be the isomorphic encoding of the concatenation of "multipart/form-data; boundary=" and the multipart/form-data
// boundary string generated by the multipart/form-data encoding algorithm.
mime_type = POSTResource::RequestContentType::MultipartFormData;
mime_type_directives.empend("boundary"sv, move(body_and_mime_type.boundary));
break;
}
case EncodingTypeAttributeState::PlainText: {
@ -796,7 +798,7 @@ ErrorOr<void> HTMLFormElement::submit_as_entity_body(URL::URL parsed_action, Vec
}
// 3. Plan to navigate to parsed action given a POST resource whose request body is body and request content-type is mimeType.
plan_to_navigate_to(parsed_action, POSTResource { .request_body = move(body), .request_content_type = mime_type }, target_navigable, history_handling, user_involvement);
plan_to_navigate_to(parsed_action, POSTResource { .request_body = move(body), .request_content_type = mime_type, .request_content_type_directives = move(mime_type_directives) }, target_navigable, history_handling, user_involvement);
return {};
}