LibJS+Everywhere: Deprecate Value::to_string_without_side_effects

Author: https://github.com/trflynn89
Commit: b245300ba1
Pull-request: https://github.com/SerenityOS/serenity/pull/17461
Reviewed-by: https://github.com/linusg

Userland/Applications/Assistant/Providers.cpp

@@ -105,7 +105,7 @@ void CalculatorProvider::query(DeprecatedString const& query, Function<void(Nonn
     if (!result.is_number()) {
         calculation = "0";
     } else {
-        calculation = result.to_string_without_side_effects();
+        calculation = result.to_deprecated_string_without_side_effects();
     }
 
     NonnullRefPtrVector<Result> results;