mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-16 13:09:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Use generated FooUnit types instead of Foo::Type

Browse source 
I've also renamed the `m_type` and `type()` members to be `m_unit` and
`unit()` instead, to match what they actually are.
This commit is contained in:
Sam Atkins 2025-09-02 13:48:49 +01:00
commit b3e32445d3
Notes: github-actions[bot] 2025-09-11 16:08:15 +00:00
29 changed files with 232 additions and 669 deletions
Download patch file Download diff file Expand all files Collapse all files

41
Libraries/LibWeb/CSS/Time.cpp
View file

@ -10,20 +10,20 @@
namespace Web::CSS {
Time::Time(double value, Type type)
: m_type(type)
Time::Time(double value, TimeUnit unit)
: m_unit(unit)
, m_value(value)
{
}
Time Time::make_seconds(double value)
{
return { value, Type::S };
return { value, TimeUnit::S };
}
Time Time::percentage_of(Percentage const& percentage) const
{
return Time { percentage.as_fraction() * m_value, m_type };
return Time { percentage.as_fraction() * m_value, m_unit };
}
String Time::to_string(SerializationMode serialization_mode) const
@ -47,10 +47,10 @@ String Time::to_string(SerializationMode serialization_mode) const
double Time::to_seconds() const
{
switch (m_type) {
case Type::S:
switch (m_unit) {
case TimeUnit::S:
return m_value;
case Type::Ms:
case TimeUnit::Ms:
return m_value / 1000.0;
}
VERIFY_NOT_REACHED();
@ -58,36 +58,15 @@ double Time::to_seconds() const
double Time::to_milliseconds() const
{
switch (m_type) {
case Type::S:
switch (m_unit) {
case TimeUnit::S:
return m_value * 1000.0;
case Type::Ms:
case TimeUnit::Ms:
return m_value;
}
VERIFY_NOT_REACHED();
}
StringView Time::unit_name() const
{
switch (m_type) {
case Type::S:
return "s"sv;
case Type::Ms:
return "ms"sv;
}
VERIFY_NOT_REACHED();
}
Optional<Time::Type> Time::unit_from_name(StringView name)
{
if (name.equals_ignoring_ascii_case("s"sv)) {
return Type::S;
} else if (name.equals_ignoring_ascii_case("ms"sv)) {
return Type::Ms;
}
return {};
}
Time Time::resolve_calculated(NonnullRefPtr<CalculatedStyleValue const> const& calculated, Layout::Node const& layout_node, Time const& reference_value)
{
CalculationResolutionContext context {