mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use infra sorting for URLSearchParam's sort()

Browse source 
Adopts editiorial change to the URL spec of:

59979a1
This commit is contained in:
Shannon Booth 2025-05-12 20:01:56 +12:00 • committed by Jelle Raaijmakers
commit b478274e0b
Notes: github-actions[bot] 2025-05-12 09:21:34 +00:00
2 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/DOMURL/URLSearchParams.cpp
View file

@ -16,6 +16,7 @@
#include <LibWeb/Bindings/URLSearchParamsPrototype.h>
#include <LibWeb/DOMURL/DOMURL.h>
#include <LibWeb/DOMURL/URLSearchParams.h>
#include <LibWeb/Infra/Strings.h>
namespace Web::DOMURL {
@ -324,20 +325,9 @@ void URLSearchParams::set(String const& name, String const& value)
// https://url.spec.whatwg.org/#dom-urlsearchparams-sort
void URLSearchParams::sort()
{
// 1. Sort all name-value pairs, if any, by their names. Sorting must be done by comparison of code units. The relative order between name-value pairs with equal names must be preserved.
// 1. Set this’s list to the result of sorting in ascending order this’s list, with a being less than b if a’s name is code unit less than b’s name.
insertion_sort(m_list, [](auto& a, auto& b) {
// FIXME: There should be a way to do this without converting to utf16
auto a_utf16 = MUST(utf8_to_utf16(a.name)).data;
auto b_utf16 = MUST(utf8_to_utf16(b.name)).data;
auto common_length = min(a_utf16.size(), b_utf16.size());
for (size_t position = 0; position < common_length; ++position) {
if (a_utf16[position] != b_utf16[position])
return a_utf16[position] < b_utf16[position];
}
return a_utf16.size() < b_utf16.size();
return Infra::code_unit_less_than(a.name, b.name);
});
// 2. Update this.