From b625a92a0bfe71563ad146f87ef926d91be7938c Mon Sep 17 00:00:00 2001 From: Jonne Ransijn Date: Thu, 7 Nov 2024 21:57:10 +0100 Subject: [PATCH] Tests: Use `FileSystem::real_path` when comparing paths Paths in `headless-browser` tests were being compared by string value. With this patch, they will be compared by their real path instead, ensuring relative paths and symlinks are handled correctly. --- Ladybird/Headless/Test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ladybird/Headless/Test.cpp b/Ladybird/Headless/Test.cpp index d1049d54647..8f48112b01b 100644 --- a/Ladybird/Headless/Test.cpp +++ b/Ladybird/Headless/Test.cpp @@ -48,7 +48,7 @@ static ErrorOr load_test_config(StringView test_root_path) for (auto const& group : config->groups()) { if (group == "Skipped"sv) { for (auto& key : config->keys(group)) - s_skipped_tests.append(LexicalPath::join(test_root_path, key).string()); + s_skipped_tests.append(TRY(FileSystem::real_path(LexicalPath::join(test_root_path, key).string()))); } else { warnln("Unknown group '{}' in config {}", group, config_path); }