From b6501adef82db8d3fd168adc99fe4ca0c8e31bde Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 1 Apr 2024 09:52:27 -0400 Subject: [PATCH] LibWeb: Use the proper in-flight request to check if a stream is closing --- .../expected/Streams/WritableStream-write.txt | 19 +++++++++++++ .../input/Streams/WritableStream-write.html | 28 +++++++++++++++++++ .../LibWeb/Streams/AbstractOperations.cpp | 2 +- 3 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 Tests/LibWeb/Text/expected/Streams/WritableStream-write.txt create mode 100644 Tests/LibWeb/Text/input/Streams/WritableStream-write.html diff --git a/Tests/LibWeb/Text/expected/Streams/WritableStream-write.txt b/Tests/LibWeb/Text/expected/Streams/WritableStream-write.txt new file mode 100644 index 00000000000..aeaaec673f0 --- /dev/null +++ b/Tests/LibWeb/Text/expected/Streams/WritableStream-write.txt @@ -0,0 +1,19 @@ +W +e +l +l +- +h +e +l +l +o +- +f +r +i +e +n +d +s +! diff --git a/Tests/LibWeb/Text/input/Streams/WritableStream-write.html b/Tests/LibWeb/Text/input/Streams/WritableStream-write.html new file mode 100644 index 00000000000..6c0239bf2e4 --- /dev/null +++ b/Tests/LibWeb/Text/input/Streams/WritableStream-write.html @@ -0,0 +1,28 @@ + + diff --git a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp index 47331d6fb91..4e05a8cb7ec 100644 --- a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp +++ b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp @@ -3492,7 +3492,7 @@ WebIDL::ExceptionOr> writable_stream_add_write bool writable_stream_close_queued_or_in_flight(WritableStream const& stream) { // 1. If stream.[[closeRequest]] is undefined and stream.[[inFlightCloseRequest]] is undefined, return false. - if (!stream.close_request() && !stream.in_flight_write_request()) + if (!stream.close_request() && !stream.in_flight_close_request()) return false; // 2. Return true.