mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 04:25:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGUI: JsonArrayModel update without invalidating indices

Browse source 
Add function to update a JsonArrayModel without invalidating it. Now,
for example in the SystemMonitor in the Network tab, a selected line
will not be deselected whenever the data is updated.
This commit is contained in:
martinfalisse 2022-02-17 08:19:38 +01:00 • committed by Andreas Kling
parent fd24782d85
commit b6c3fad078
Notes: sideshowbarker 2024-07-17 18:37:27 +09:00
3 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp
View file

@ -114,7 +114,7 @@ NetworkStatisticsWidget::NetworkStatisticsWidget()
void NetworkStatisticsWidget::update_models()
{
m_adapter_model->invalidate();
m_tcp_socket_model->invalidate();
m_udp_socket_model->invalidate();
m_adapter_model->update();
m_tcp_socket_model->update();
m_udp_socket_model->update();
}

18
Userland/Libraries/LibGUI/JsonArrayModel.cpp
View file

@ -28,6 +28,24 @@ void JsonArrayModel::invalidate()
did_update();
}
void JsonArrayModel::update()
{
auto file = Core::File::construct(m_json_path);
if (!file->open(Core::OpenMode::ReadOnly)) {
dbgln("Unable to open {}", file->filename());
m_array.clear();
did_update();
return;
}
auto json = JsonValue::from_string(file->read_all()).release_value_but_fixme_should_propagate_errors();
VERIFY(json.is_array());
m_array = json.as_array();
did_update(GUI::Model::UpdateFlag::DontInvalidateIndices);
}
bool JsonArrayModel::store()
{
auto file = Core::File::construct(m_json_path);

1
Userland/Libraries/LibGUI/JsonArrayModel.h
View file

@ -51,6 +51,7 @@ public:
virtual String column_name(int column) const override { return m_fields[column].column_name; }
virtual Variant data(const ModelIndex&, ModelRole = ModelRole::Display) const override;
virtual void invalidate() override;
virtual void update();
const String& json_path() const { return m_json_path; }
void set_json_path(const String& json_path);