mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-19 15:58:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Shell: Correctly auto format command lines consisting of only whitespace

Browse source 
When the command line consists of only whitespace characters, the auto
formatter basically tries to trim the trailing whitespace. But due to a
subtle bug of decrementing an iterator (which is an unsigned integer)
past 0 (or the start of the buffer), that operation resulted in an index
out of bounds error and a crash.
This commit is contained in:
ronak69 2024-03-27 17:54:56 +00:00 • committed by Ali Mohammad Pur
commit b6cf62d00a
Notes: sideshowbarker 2024-07-17 01:11:48 +09:00
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Shell/Formatter.h
View file

@ -30,8 +30,11 @@ public:
return;
size_t offset = 0;
for (auto ptr = m_source.end() - 1; ptr >= m_source.begin() && isspace(*ptr); --ptr)
for (auto ptr = m_source.end() - 1; isspace(*ptr); --ptr) {
++offset;
if (ptr == m_source.begin())
break;
}
m_trivia = m_source.substring_view(m_source.length() - offset, offset);
}