RequestServer: Don't assert for socket fd not being CURL_SOCKET_BAD

The assertion in `WebSocketImplCurl::did_connect()` keeps failing for multiple websockets when loading `https://www.speedtest.net/` since commit 14ebcd4. This fixes that by checking and returning false if something went wrong and letting the caller function handle it.
Author: https://github.com/mobounya Commit: b77643a2e8 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3930 Reviewed-by: https://github.com/ADKaster ✅
2025-08-01 05:39:11 +00:00 · 2025-03-14 01:13:04 +00:00 · 2025-03-14 01:13:04 +00:00 · b77643a2e8 · 2025-05-01 00:21:27 +00:00
commit b77643a2e8
parent 82387e2127
3 changed files with 10 additions and 6 deletions
--- a/Services/RequestServer/WebSocketImplCurl.h
+++ b/Services/RequestServer/WebSocketImplCurl.h
@ -29,7 +29,7 @@ public:

    virtual bool handshake_complete_when_connected() const override { return true; }

-    void did_connect();
+    bool did_connect();

 private:
    explicit WebSocketImplCurl(CURLM*);