mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove XML-derived attribute name validation from DOMStringMap

Browse source 
Corresponds to 841fcfdb2c
This commit is contained in:
Sam Atkins 2025-07-17 09:53:47 +01:00 • committed by Jelle Raaijmakers
commit b7b504cf2d
Notes: github-actions[bot] 2025-07-17 11:55:16 +00:00
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/DOM/Element.cpp
View file

@ -237,6 +237,7 @@ bool is_valid_namespace_prefix(FlyString const& prefix)
return !prefix.is_empty() && !prefix.code_points().contains_any_of(INVALID_NAMESPACE_PREFIX_CHARACTERS);
}
// https://dom.spec.whatwg.org/#valid-attribute-local-name
bool is_valid_attribute_local_name(FlyString const& local_name)
{
// A string is a valid attribute local name if its length is at least 1 and it does not contain ASCII whitespace, U+0000 NULL, U+002F (/), U+003D (=), or U+003E (>).

4
Libraries/LibWeb/HTML/DOMStringMap.cpp
View file

@ -162,7 +162,9 @@ WebIDL::ExceptionOr<void> DOMStringMap::set_value_of_new_named_property(String c
auto data_name = MUST(builder.to_string());
// FIXME: 4. If name does not match the XML Name production, throw an "InvalidCharacterError" DOMException.
// 4. If name is not a valid attribute local name, then throw an "InvalidCharacterError" DOMException.
if (!DOM::is_valid_attribute_local_name(data_name))
return WebIDL::InvalidCharacterError::create(realm(), "Name is not a valid attribute local name."_string);
// 5. Set an attribute value for the DOMStringMap's associated element using name and value.
TRY(m_associated_element->set_attribute(data_name, value));