mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/SVG: Work around no layout node in SVGCircleElement::get_path

Browse source 
This is clearly not the correct fix, but instead of crashing let's
log an error and bail.

Works around a crash seen on both:

 * https://reddit.com
 * https://www.w3.org/TR/web-animations-1 (#879)
This commit is contained in:
Shannon Booth 2025-03-16 20:56:04 +13:00 • committed by Alexander Kalenik
parent c85df78c4c
commit b8adf193f5
Notes: github-actions[bot] 2025-03-17 19:11:03 +00:00
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/SVG/SVGCircleElement.cpp
View file

@ -61,6 +61,11 @@ void SVGCircleElement::apply_presentational_hints(GC::Ref<CSS::CascadedPropertie
Gfx::Path SVGCircleElement::get_path(CSSPixelSize viewport_size)
{
auto node = layout_node();
if (!node) {
dbgln("FIXME: Null layout node in SVGCircleElement::get_path");
return {};
}
auto cx = float(node->computed_values().cx().to_px(*node, viewport_size.width()));
auto cy = float(node->computed_values().cy().to_px(*node, viewport_size.height()));
// Percentages refer to the normalized diagonal of the current SVG viewport

6
Tests/LibWeb/Crash/Layout/svg-circle-element-crash-no-layout-node.html Normal file
View file

@ -0,0 +1,6 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 200 200">
<g mask="url(#excludedEndPoints)"></g>
<mask id="excludedEndPoints">
<circle cx="50" cy="50" r="4" fill="black" stroke="black"/>
</mask>
</svg>
Side by side

After

Width:  |  Height:  |  Size: 209 B