mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash with invalid transform-origin values
Some checks are pending
CI / macOS, arm64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Gingeh 2025-07-01 20:25:03 +10:00 • committed by Sam Atkins
commit b8f78e3bc1
Notes: github-actions[bot] 2025-07-01 13:20:25 +00:00
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -3907,14 +3907,14 @@ RefPtr<CSSStyleValue const> Parser::parse_transform_origin_value(TokenStream<Com
auto second_value = to_axis_offset(parse_css_value_for_property(PropertyID::TransformOrigin, tokens)); auto second_value = to_axis_offset(parse_css_value_for_property(PropertyID::TransformOrigin, tokens));
auto third_value = parse_length_value(tokens); auto third_value = parse_length_value(tokens);
if (!first_value.has_value() || !second_value.has_value())
return nullptr;
if ((first_value->offset->is_length() || first_value->offset->is_percentage()) && second_value->axis == Axis::X) if ((first_value->offset->is_length() || first_value->offset->is_percentage()) && second_value->axis == Axis::X)
return nullptr; return nullptr;
if ((second_value->offset->is_length() || second_value->offset->is_percentage()) && first_value->axis == Axis::Y) if ((second_value->offset->is_length() || second_value->offset->is_percentage()) && first_value->axis == Axis::Y)
return nullptr; return nullptr;
if (!first_value.has_value() || !second_value.has_value())
return nullptr;
if (!third_value) if (!third_value)
third_value = zero_value; third_value = zero_value;

1
Tests/LibWeb/Text/expected/invalid-transform-origin.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

8
Tests/LibWeb/Text/input/invalid-transform-origin.html Normal file
View file

@ -0,0 +1,8 @@
<!DOCTYPE html>
<script src="include.js"></script>
<div style="transform-origin: bad value"></div>
<script>
test(() => {
println("PASS (didn't crash)");
});
</script>