mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-26 01:50:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb+LibXML: Make Listener::set_source(ByteString) fallible
Some checks are pending
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
`set_source` takes a ByteString but the implementation might require a
specific encoding. Make it fallible so that we don't need to crash in
the case of invalid UTF-8 or similar.

The test includes a sequence of invalid UTF-8 bytes that crash the
browser without this change.
This commit is contained in:
rmg-x 2025-09-30 10:53:41 -05:00 • committed by Ali Mohammad Pur
commit b9554038ff
Notes: github-actions[bot] 2025-10-02 00:27:16 +00:00
7 changed files with 25 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibXML/Parser/Parser.cpp
View file

@ -199,7 +199,12 @@ ErrorOr<void, ParseError> Parser::parse_with_listener(Listener& listener)
{
m_listener = &listener;
ScopeGuard unset_listener { [this] { m_listener = nullptr; } };
m_listener->set_source(m_source);
if (auto const maybe_source_error = m_listener->set_source(m_source); maybe_source_error.is_error()) {
auto const error_message = maybe_source_error.error().string_literal();
return parse_error(m_lexer.current_position(), Expectation { error_message });
}
m_listener->document_start();
auto result = parse_internal();
if (result.is_error())