mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use correct case-sensitivity when matching attribute selectors

Browse source 
Also removed get_attribute_with_lowercase_qualified_name
because it was buggy, duplicated logic, and now unused.
This commit is contained in:
Gingeh 2024-11-21 20:43:10 +11:00 • committed by Andreas Kling
commit ba0cc7fe46
Notes: github-actions[bot] 2024-11-23 08:51:33 +00:00
4 changed files with 12 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/CSS/SelectorEngine.cpp
View file

@ -219,8 +219,7 @@ static inline bool matches_attribute(CSS::Selector::SimpleSelector::Attribute co
auto const& attribute_name = attribute.qualified_name.name.name;
auto const* attr = element.namespace_uri() == Namespace::HTML ? element.attributes()->get_attribute_with_lowercase_qualified_name(attribute_name)
: element.attributes()->get_attribute(attribute_name);
auto const* attr = element.attributes()->get_attribute(attribute_name);
if (attribute.match_type == CSS::Selector::SimpleSelector::Attribute::MatchType::HasAttribute) {
// Early way out in case of an attribute existence selector.