mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Remove irrelevant FIXMEs about implementing some module hooks

Browse source 
Both of these module-related host hooks are not present in the latest
version of the HTML spec.
This commit is contained in:
Shannon Booth 2024-12-01 13:09:45 +13:00 • committed by Andreas Kling
parent 5af613aa65
commit bb68f09855
Notes: github-actions[bot] 2024-12-01 11:26:45 +00:00
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/Bindings/MainThreadVM.cpp
View file

@ -380,7 +380,7 @@ ErrorOr<void> initialize_main_thread_vm(HTML::EventLoop::Type type)
return JS::JobCallback::create(*s_main_thread_vm, callable, move(host_defined));
};
// 8.1.5.5.1 HostGetImportMetaProperties(moduleRecord), https://html.spec.whatwg.org/multipage/webappapis.html#hostgetimportmetaproperties
// 8.1.6.7.1 HostGetImportMetaProperties(moduleRecord), https://html.spec.whatwg.org/multipage/webappapis.html#hostgetimportmetaproperties
s_main_thread_vm->host_get_import_meta_properties = [](JS::SourceTextModule& module_record) {
auto& realm = module_record.realm();
auto& vm = realm.vm();
@ -421,10 +421,7 @@ ErrorOr<void> initialize_main_thread_vm(HTML::EventLoop::Type type)
return meta;
};
// FIXME: Implement 8.1.5.5.2 HostImportModuleDynamically(referencingScriptOrModule, moduleRequest, promiseCapability), https://html.spec.whatwg.org/multipage/webappapis.html#hostimportmoduledynamically(referencingscriptormodule,-modulerequest,-promisecapability)
// FIXME: Implement 8.1.5.5.3 HostResolveImportedModule(referencingScriptOrModule, moduleRequest), https://html.spec.whatwg.org/multipage/webappapis.html#hostresolveimportedmodule(referencingscriptormodule,-modulerequest)
// 8.1.6.5.2 HostGetSupportedImportAttributes(), https://html.spec.whatwg.org/multipage/webappapis.html#hostgetsupportedimportassertions
// 8.1.6.7.2 HostGetSupportedImportAttributes(), https://html.spec.whatwg.org/multipage/webappapis.html#hostgetsupportedimportassertions
s_main_thread_vm->host_get_supported_import_attributes = []() -> Vector<ByteString> {
// 1. Return « "type" ».
return { "type"sv };