mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-16 05:51:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Mark most stream callbacks as infallible

Browse source 
There are a number of script-provided stream callbacks for various
stream operations, such as `start`, `pull`, `cancel`, etc. Out of all of
these, only the `start` callback can actually throw. And when it does,
the exception is realized immediately in the corresponding stream
constructor.

All other callbacks have spec text of the form:

    Throwing an exception is treated the same as returning a rejected
    promise.

And indeed this is internally handled by the streams spec. Thus all of
those callbacks can be specified as returning only a promise, rather
than a WebIDL::ExceptionOr<Promise>.
This commit is contained in:
Timothy Flynn 2024-04-29 16:17:32 -04:00 • committed by Andreas Kling
parent ffb48ccd81
commit bbe6b84bd6
Notes: sideshowbarker 2024-07-17 03:19:14 +09:00
6 changed files with 106 additions and 112 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Streams/ReadableStreamDefaultController.cpp
View file

@ -101,7 +101,7 @@ WebIDL::ExceptionOr<void> ReadableStreamDefaultController::pull_steps(Web::Strea
}
// 3. Otherwise, perform ! ReadableStreamDefaultControllerCallPullIfNeeded(this).
else {
TRY(readable_stream_default_controller_can_pull_if_needed(*this));
readable_stream_default_controller_can_pull_if_needed(*this);
}
// 4. Perform readRequest’s chunk steps, given chunk.
@ -113,7 +113,7 @@ WebIDL::ExceptionOr<void> ReadableStreamDefaultController::pull_steps(Web::Strea
readable_stream_add_read_request(stream, read_request);
// 2. Perform ! ReadableStreamDefaultControllerCallPullIfNeeded(this).
TRY(readable_stream_default_controller_can_pull_if_needed(*this));
readable_stream_default_controller_can_pull_if_needed(*this);
}
return {};