mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 20:59:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Replace Parser "current property" with a stack of contexts

Browse source 
`current_property_id()` is insufficient to determine if a quirk is
allowed. For example, unitless lengths are allowed in certain
properties, but NOT if they are inside a calc() or other function. It's
also incorrect when we are parsing a longhand inside a shorthand. So
instead, replace that with a stack of value-parsing contexts. For now,
this is either properties or CSS functions, but in future can be
expanded to include media features and other places.

This lets us disallow quirks inside functions, like we're supposed to.

It also lays the groundwork for being able to more easily determine
what type a percentage inside a calculation should become, as this is
based on the same stack of contexts.
This commit is contained in:
Sam Atkins 2025-01-06 12:48:17 +00:00
commit bc00ef8314
Notes: github-actions[bot] 2025-01-13 11:00:39 +00:00
4 changed files with 196 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/CSS/Parser/Parser.h
View file

@ -443,6 +443,18 @@ private:
Vector<Token> m_tokens;
TokenStream<Token> m_token_stream;
struct FunctionContext {
StringView name;
};
using ValueParsingContext = Variant<PropertyID, FunctionContext>;
Vector<ValueParsingContext> m_value_context;
auto push_temporary_value_parsing_context(ValueParsingContext&& context)
{
m_value_context.append(context);
return ScopeGuard { [&] { m_value_context.take_last(); } };
}
bool context_allows_quirky_length() const;
enum class ContextType {
Unknown,
Style,