mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-24 02:08:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Correctly skip "decimal" in counter() serialization

Browse source 
It's not a keyword, it's a custom-ident. The simplest way of comparing
is by serializing it as a string.

This gets us 2 subtest passes.
This commit is contained in:
Sam Atkins 2024-11-28 16:36:07 +00:00 • committed by Andreas Kling
commit bc17a3c2eb
Notes: github-actions[bot] 2024-11-30 10:03:08 +00:00
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/StyleValues/CounterStyleValue.cpp
View file

@ -151,7 +151,7 @@ String CounterStyleValue::to_string() const
list.append(CustomIdentStyleValue::create(m_properties.counter_name)); list.append(CustomIdentStyleValue::create(m_properties.counter_name));
if (m_properties.function == CounterFunction::Counters) if (m_properties.function == CounterFunction::Counters)
list.append(StringStyleValue::create(m_properties.join_string.to_string())); list.append(StringStyleValue::create(m_properties.join_string.to_string()));
if (m_properties.counter_style->to_keyword() != Keyword::Decimal) if (m_properties.counter_style->to_string() != "decimal"sv)
list.append(m_properties.counter_style); list.append(m_properties.counter_style);
// 5. Let each item in list be the result of invoking serialize a CSS component value on that item. // 5. Let each item in list be the result of invoking serialize a CSS component value on that item.

8
Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt
View file

@ -6,8 +6,8 @@ Rerun
Found 687 tests Found 687 tests
464 Pass 466 Pass
223 Fail 221 Fail
Details Details
Result Test Name MessagePass background-attachment: scroll Result Test Name MessagePass background-attachment: scroll
Pass background-attachment: fixed Pass background-attachment: fixed
@ -329,8 +329,8 @@ Pass content: "string"
Pass content: 'string' Pass content: 'string'
Fail content: url("http://localhost/") Fail content: url("http://localhost/")
Fail content: url(http://localhost/) Fail content: url(http://localhost/)
Fail content: counter(par-num) Pass content: counter(par-num)
Fail content: counter(par-num, decimal) Pass content: counter(par-num, decimal)
Pass content: counter(par-num, upper-roman) Pass content: counter(par-num, upper-roman)
Pass content: attr(foo-bar) Pass content: attr(foo-bar)
Pass content: attr(foo_bar) Pass content: attr(foo_bar)