mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-26 20:26:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb: Make signature of CSS::{Percentage,Number}::to_string consistent

Browse source 
By making this consistent with the other numeric data type classes we
can simplify cases where we are dealing with variants containing these
types.
This commit is contained in:
Callum Law 2025-08-06 22:19:09 +12:00 • committed by Sam Atkins
commit bc2ca96f50
Notes: github-actions[bot] 2025-08-11 16:11:16 +00:00
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/Number.cpp
View file

@ -9,7 +9,7 @@
namespace Web::CSS { namespace Web::CSS {
String Number::to_string() const String Number::to_string(SerializationMode) const
{ {
if (m_type == Type::IntegerWithExplicitSign) if (m_type == Type::IntegerWithExplicitSign)
return MUST(String::formatted("{:+}", m_value)); return MUST(String::formatted("{:+}", m_value));

3
Libraries/LibWeb/CSS/Number.h
View file

@ -8,6 +8,7 @@
#include <AK/String.h> #include <AK/String.h>
#include <AK/Types.h> #include <AK/Types.h>
#include <LibWeb/CSS/SerializationMode.h>
#include <math.h> #include <math.h>
namespace Web::CSS { namespace Web::CSS {
@ -70,7 +71,7 @@ public:
return { Type::Number, m_value / other.m_value }; return { Type::Number, m_value / other.m_value };
} }
String to_string() const; String to_string(SerializationMode = SerializationMode::Normal) const;
bool operator==(Number const& other) const bool operator==(Number const& other) const
{ {

4
Libraries/LibWeb/CSS/Percentage.h
View file

@ -8,6 +8,8 @@
#include <AK/String.h> #include <AK/String.h>
#include <AK/Variant.h> #include <AK/Variant.h>
#include <LibWeb/CSS/SerializationMode.h>
namespace Web::CSS { namespace Web::CSS {
class Percentage { class Percentage {
@ -20,7 +22,7 @@ public:
double value() const { return m_value; } double value() const { return m_value; }
double as_fraction() const { return m_value * 0.01; } double as_fraction() const { return m_value * 0.01; }
String to_string() const String to_string(SerializationMode = SerializationMode::Normal) const
{ {
return MUST(String::formatted("{}%", m_value)); return MUST(String::formatted("{}%", m_value));
} }