From bc67bdb160ca9127bfed659988b03714b417b724 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 28 Oct 2024 15:21:53 -0400 Subject: [PATCH] LibWeb+UI: Initialize the system visibility state to 'hidden' Not only does this match the spec, but otherwise when the UI process sends us the initial visibility update, we would ignore the message as we believed we were already visible (thus the update would not reach the document). --- Ladybird/Headless/HeadlessWebView.cpp | 1 + Userland/Libraries/LibWeb/HTML/TraversableNavigable.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Ladybird/Headless/HeadlessWebView.cpp b/Ladybird/Headless/HeadlessWebView.cpp index 5f7dd72944d..f845392922f 100644 --- a/Ladybird/Headless/HeadlessWebView.cpp +++ b/Ladybird/Headless/HeadlessWebView.cpp @@ -128,6 +128,7 @@ void HeadlessWebView::initialize_client(CreateNewClient create_new_client) client().async_set_window_handle(m_client_state.page_index, m_client_state.client_handle); client().async_update_system_theme(m_client_state.page_index, m_theme); + client().async_set_system_visibility_state(m_client_state.page_index, true); client().async_set_viewport_size(m_client_state.page_index, viewport_size()); client().async_set_window_size(m_client_state.page_index, viewport_size()); diff --git a/Userland/Libraries/LibWeb/HTML/TraversableNavigable.h b/Userland/Libraries/LibWeb/HTML/TraversableNavigable.h index ebefda9a999..c2cd076e8c0 100644 --- a/Userland/Libraries/LibWeb/HTML/TraversableNavigable.h +++ b/Userland/Libraries/LibWeb/HTML/TraversableNavigable.h @@ -138,7 +138,7 @@ private: bool m_running_nested_apply_history_step { false }; // https://html.spec.whatwg.org/multipage/document-sequences.html#system-visibility-state - VisibilityState m_system_visibility_state { VisibilityState::Visible }; + VisibilityState m_system_visibility_state { VisibilityState::Hidden }; JS::NonnullGCPtr m_session_history_traversal_queue;