mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-02 06:09:08 +00:00
LibJS: Fix PropertyName::from_value() for negative and non-int numbers
It was converting *any* number to an i32 index, which obviously is not correct for negative ints, doubles, infinity and nan. Fixes #3712.
This commit is contained in:
parent
44d4423229
commit
bc78e4b7da
Notes:
sideshowbarker
2024-07-19 01:58:43 +09:00
Author: https://github.com/linusg
Commit: bc78e4b7da
Pull-request: https://github.com/SerenityOS/serenity/pull/3713
Issue: https://github.com/SerenityOS/serenity/issues/3712
2 changed files with 16 additions and 4 deletions
12
Libraries/LibJS/Tests/object-expression-computed-property.js
Normal file
12
Libraries/LibJS/Tests/object-expression-computed-property.js
Normal file
|
@ -0,0 +1,12 @@
|
|||
test("Issue #3712, negative/non-int computed property in object expression", () => {
|
||||
const o = {
|
||||
[1.23]: "foo",
|
||||
[-1]: "foo",
|
||||
[NaN]: "foo",
|
||||
[Infinity]: "foo",
|
||||
};
|
||||
expect(o[1.23]).toBe("foo");
|
||||
expect(o[-1]).toBe("foo");
|
||||
expect(o[NaN]).toBe("foo");
|
||||
expect(o[Infinity]).toBe("foo");
|
||||
});
|
Loading…
Add table
Add a link
Reference in a new issue