mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 08:39:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Don't return any errors for update_the_img_data

Browse source 
There should not be any exceptions to propagate, so let's update
the return type accordingly.
This commit is contained in:
Shannon Booth 2025-06-21 14:44:03 +12:00 • committed by Jelle Raaijmakers
commit bc85a9bace
Notes: github-actions[bot] 2025-06-24 07:57:38 +00:00
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -133,7 +133,7 @@ void HTMLImageElement::form_associated_element_attribute_changed(FlyString const
} }
if (name.is_one_of(HTML::AttributeNames::src, HTML::AttributeNames::srcset)) { if (name.is_one_of(HTML::AttributeNames::src, HTML::AttributeNames::srcset)) {
update_the_image_data(true).release_value_but_fixme_should_propagate_errors(); update_the_image_data(true);
} }
if (name == HTML::AttributeNames::alt) { if (name == HTML::AttributeNames::alt) {
@ -480,7 +480,7 @@ static BatchingDispatcher& batching_dispatcher()
} }
// https://html.spec.whatwg.org/multipage/images.html#update-the-image-data // https://html.spec.whatwg.org/multipage/images.html#update-the-image-data
ErrorOr<void> HTMLImageElement::update_the_image_data(bool restart_animations, bool maybe_omit_events) void HTMLImageElement::update_the_image_data(bool restart_animations, bool maybe_omit_events)
{ {
// 1. If the element's node document is not fully active, then: // 1. If the element's node document is not fully active, then:
if (!document().is_fully_active()) { if (!document().is_fully_active()) {
@ -572,7 +572,7 @@ ErrorOr<void> HTMLImageElement::update_the_image_data(bool restart_animations, b
}); });
// 8. Abort the update the image data algorithm. // 8. Abort the update the image data algorithm.
return {}; return;
} }
} }
after_step_7: after_step_7:
@ -730,7 +730,6 @@ after_step_7:
image_request->fetch_image(realm(), request); image_request->fetch_image(realm(), request);
})); }));
return {};
} }
void HTMLImageElement::add_callbacks_to_image_request(GC::Ref<ImageRequest> image_request, bool maybe_omit_events, URL::URL const& url_string, String const& previous_url) void HTMLImageElement::add_callbacks_to_image_request(GC::Ref<ImageRequest> image_request, bool maybe_omit_events, URL::URL const& url_string, String const& previous_url)

2
Libraries/LibWeb/HTML/HTMLImageElement.h
View file

@ -76,7 +76,7 @@ public:
void react_to_changes_in_the_environment(); void react_to_changes_in_the_environment();
// https://html.spec.whatwg.org/multipage/images.html#update-the-image-data // https://html.spec.whatwg.org/multipage/images.html#update-the-image-data
ErrorOr<void> update_the_image_data(bool restart_the_animations = false, bool maybe_omit_events = false); void update_the_image_data(bool restart_the_animations = false, bool maybe_omit_events = false);
// https://html.spec.whatwg.org/multipage/images.html#use-srcset-or-picture // https://html.spec.whatwg.org/multipage/images.html#use-srcset-or-picture
[[nodiscard]] bool uses_srcset_or_picture() const; [[nodiscard]] bool uses_srcset_or_picture() const;