mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibRegex: Correctly use ClassSetReservedPunctuator in ClassSetCharacter
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
We had typo'd using ClassSetReservedDoublePunctuator which was
resulting in a parse error for the regex:

([^\\:]+?)

With the 'v' flag set.

Co-Authored-By: Ali Mohammad Pur <mpfard@serenityos.org>
This commit is contained in:
Shannon Booth 2025-07-10 21:10:00 +12:00 • committed by Ali Mohammad Pur
commit bd6581fe22
Notes: github-actions[bot] 2025-07-10 09:42:19 +00:00
2 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibRegex/RegexParser.cpp
View file

@ -2266,6 +2266,10 @@ Optional<u32> ECMA262Parser::parse_class_set_character()
"&&"sv, "!!"sv, "##"sv, "$$"sv, "%%"sv, "**"sv, "++"sv, ",,"sv, ".."sv, "::"sv, ";;"sv, "<<"sv, "=="sv, ">>"sv, "??"sv, "@@"sv, "^^"sv, "``"sv, "~~"sv
};
constexpr auto class_set_reserved_punctuator = Array {
"&"sv, "-"sv, "!"sv, "#"sv, "%"sv, ","sv, ":"sv, ";"sv, "<"sv, "="sv, ">"sv, "@"sv, "`"sv, "~"sv
};
if (done()) {
set_error(Error::InvalidPattern);
return {};
@ -2281,7 +2285,7 @@ Optional<u32> ECMA262Parser::parse_class_set_character()
}
// "\" ClassSetReservedPunctuator
for (auto const& reserved : class_set_reserved_double_punctuator) {
for (auto const& reserved : class_set_reserved_punctuator) {
if (try_skip(reserved)) {
// "\" ClassSetReservedPunctuator (ClassSetReservedPunctuator)
back();

18
Tests/LibRegex/TestRegex.cpp
View file

@ -753,6 +753,23 @@ TEST_CASE(ECMA262_match)
}
}
TEST_CASE(ECMA262_unicode_parser_error)
{
struct _test {
StringView pattern;
regex::Error error;
};
constexpr _test tests[] {
{ "([^\\:]+?)"sv, regex::Error::InvalidPattern },
};
for (auto test : tests) {
Regex<ECMA262> re(test.pattern, (ECMAScriptFlags)regex::AllFlags::Unicode);
EXPECT_EQ(re.parser_result.error, test.error);
}
}
TEST_CASE(ECMA262_unicode_match)
{
constexpr auto space_and_line_terminator_code_points = Array { 0x0009, 0x000A, 0x000B, 0x000C, 0x000D, 0x0020, 0x00A0, 0x1680, 0x2000, 0x2001, 0x2002, 0x2003, 0x2004, 0x2005, 0x2006, 0x2007, 0x2008, 0x2009, 0x200A, 0x2028, 0x2029, 0x202F, 0x205F, 0x3000, 0xFEFF };
@ -859,6 +876,7 @@ TEST_CASE(ECMA262_unicode_sets_match)
{ "[[0-9\\w]--x--6]"sv, "9"sv, true },
{ "[\\w&&\\d]"sv, "a"sv, false },
{ "[\\w&&\\d]"sv, "4"sv, true },
{ "([^\\:]+?)"sv, "a"sv, true },
};
for (auto& test : tests) {