mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 12:49:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Re-evaluate the style block when the type attribute changes
Some checks are pending
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Hikmat Jafarli 2025-04-28 22:34:44 +04:00 • committed by Andreas Kling
commit bd9d489370
Notes: github-actions[bot] 2025-04-28 23:01:58 +00:00
3 changed files with 49 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLStyleElement.cpp
View file

@ -59,6 +59,8 @@ void HTMLStyleElement::attribute_changed(FlyString const& name, Optional<String>
if (name == HTML::AttributeNames::media) {
if (auto* sheet = m_style_element_utils.sheet())
sheet->set_media(value.value_or({}));
} else if (name == HTML::AttributeNames::type) {
m_style_element_utils.update_a_style_block(*this);
}
}

8
Tests/LibWeb/Text/expected/wpt-import/html/semantics/document-metadata/the-style-element/style_type_change.txt Normal file
View file

@ -0,0 +1,8 @@
Harness status: OK
Found 3 tests
3 Pass
Pass Check initial styleSheets length type
Pass Change type from invalid type to valid type
Pass Change type from valid type to invalid type

39
Tests/LibWeb/Text/input/wpt-import/html/semantics/document-metadata/the-style-element/style_type_change.html Normal file
View file

@ -0,0 +1,39 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Dynamically changing HTMLStyleElement.type should change the rendering accordingly</title>
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<link rel="help" href="https://html.spec.whatwg.org/multipage/#the-style-element">
<style type="no/mime">
body { color: green }
</style>
</head>
<body>
Text content.
<script>
var style = document.querySelector("style");
test(function() {
assert_equals(document.styleSheets.length, 0);
}, "Check initial styleSheets length type");
test(function() {
assert_not_equals(getComputedStyle(document.querySelector("body")).color, "rgb(0, 128, 0)");
assert_equals(document.styleSheets.length, 0);
style.type = "text/css";
assert_equals(getComputedStyle(document.querySelector("body")).color, "rgb(0, 128, 0)");
assert_equals(document.styleSheets.length, 1);
}, "Change type from invalid type to valid type");
test(function() {
assert_equals(getComputedStyle(document.querySelector("body")).color, "rgb(0, 128, 0)");
assert_equals(document.styleSheets.length, 1);
style.type = "no/mime";
assert_not_equals(getComputedStyle(document.querySelector("body")).color, "rgb(0, 128, 0)");
assert_equals(document.styleSheets.length, 0);
}, "Change type from valid type to invalid type");
</script>
</body>
</html>