mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-07 08:39:22 +00:00
LibDevTools+LibWebView: Implement requests to edit DOM node tags
This commit is contained in:
parent
17fb21169f
commit
bdb31b029a
Notes:
github-actions[bot]
2025-03-08 00:27:13 +00:00
Author: https://github.com/trflynn89
Commit: bdb31b029a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3850
4 changed files with 44 additions and 0 deletions
|
@ -73,6 +73,41 @@ void WalkerActor::handle_message(StringView type, JsonObject const& message)
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (type == "editTagName"sv) {
|
||||||
|
auto node = message.get_string("node"sv);
|
||||||
|
if (!node.has_value()) {
|
||||||
|
send_missing_parameter_error("node"sv);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
auto tag_name = message.get_string("tagName"sv);
|
||||||
|
if (!tag_name.has_value()) {
|
||||||
|
send_missing_parameter_error("tagName"sv);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (auto dom_node = WalkerActor::dom_node_for(*this, *node); dom_node.has_value()) {
|
||||||
|
auto block_token = block_responses();
|
||||||
|
|
||||||
|
devtools().delegate().set_dom_node_tag(
|
||||||
|
dom_node->tab->description(), dom_node->identifier.id, tag_name.release_value(),
|
||||||
|
[weak_self = make_weak_ptr<WalkerActor>(), block_token = move(block_token)](ErrorOr<Web::UniqueNodeID> node_id) mutable {
|
||||||
|
if (node_id.is_error()) {
|
||||||
|
dbgln_if(DEVTOOLS_DEBUG, "Unable to edit DOM node: {}", node_id.error());
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (auto self = weak_self.strong_ref()) {
|
||||||
|
JsonObject message;
|
||||||
|
message.set("from"sv, self->name());
|
||||||
|
self->send_message(move(message), move(block_token));
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
if (type == "getLayoutInspector"sv) {
|
if (type == "getLayoutInspector"sv) {
|
||||||
if (!m_layout_inspector)
|
if (!m_layout_inspector)
|
||||||
m_layout_inspector = devtools().register_actor<LayoutInspectorActor>();
|
m_layout_inspector = devtools().register_actor<LayoutInspectorActor>();
|
||||||
|
|
|
@ -43,6 +43,7 @@ public:
|
||||||
|
|
||||||
using OnDOMNodeEditComplete = Function<void(ErrorOr<Web::UniqueNodeID>)>;
|
using OnDOMNodeEditComplete = Function<void(ErrorOr<Web::UniqueNodeID>)>;
|
||||||
virtual void set_dom_node_text(TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const { }
|
virtual void set_dom_node_text(TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const { }
|
||||||
|
virtual void set_dom_node_tag(TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const { }
|
||||||
virtual void add_dom_node_attributes(TabDescription const&, Web::UniqueNodeID, Vector<WebView::Attribute>, OnDOMNodeEditComplete) const { }
|
virtual void add_dom_node_attributes(TabDescription const&, Web::UniqueNodeID, Vector<WebView::Attribute>, OnDOMNodeEditComplete) const { }
|
||||||
virtual void replace_dom_node_attribute(TabDescription const&, Web::UniqueNodeID, String, Vector<WebView::Attribute>, OnDOMNodeEditComplete) const { }
|
virtual void replace_dom_node_attribute(TabDescription const&, Web::UniqueNodeID, String, Vector<WebView::Attribute>, OnDOMNodeEditComplete) const { }
|
||||||
|
|
||||||
|
|
|
@ -465,6 +465,13 @@ void Application::set_dom_node_text(DevTools::TabDescription const& description,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void Application::set_dom_node_tag(DevTools::TabDescription const& description, Web::UniqueNodeID node_id, String value, OnDOMNodeEditComplete on_complete) const
|
||||||
|
{
|
||||||
|
edit_dom_node(description, move(on_complete), [&](auto& view) {
|
||||||
|
view.set_dom_node_tag(node_id, move(value));
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
void Application::add_dom_node_attributes(DevTools::TabDescription const& description, Web::UniqueNodeID node_id, Vector<Attribute> replacement_attributes, OnDOMNodeEditComplete on_complete) const
|
void Application::add_dom_node_attributes(DevTools::TabDescription const& description, Web::UniqueNodeID node_id, Vector<Attribute> replacement_attributes, OnDOMNodeEditComplete on_complete) const
|
||||||
{
|
{
|
||||||
edit_dom_node(description, move(on_complete), [&](auto& view) {
|
edit_dom_node(description, move(on_complete), [&](auto& view) {
|
||||||
|
|
|
@ -99,6 +99,7 @@ private:
|
||||||
virtual void listen_for_dom_mutations(DevTools::TabDescription const&, OnDOMMutationReceived) const override;
|
virtual void listen_for_dom_mutations(DevTools::TabDescription const&, OnDOMMutationReceived) const override;
|
||||||
virtual void stop_listening_for_dom_mutations(DevTools::TabDescription const&) const override;
|
virtual void stop_listening_for_dom_mutations(DevTools::TabDescription const&) const override;
|
||||||
virtual void set_dom_node_text(DevTools::TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const override;
|
virtual void set_dom_node_text(DevTools::TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const override;
|
||||||
|
virtual void set_dom_node_tag(DevTools::TabDescription const&, Web::UniqueNodeID, String, OnDOMNodeEditComplete) const override;
|
||||||
virtual void add_dom_node_attributes(DevTools::TabDescription const&, Web::UniqueNodeID, Vector<Attribute>, OnDOMNodeEditComplete) const override;
|
virtual void add_dom_node_attributes(DevTools::TabDescription const&, Web::UniqueNodeID, Vector<Attribute>, OnDOMNodeEditComplete) const override;
|
||||||
virtual void replace_dom_node_attribute(DevTools::TabDescription const&, Web::UniqueNodeID, String, Vector<Attribute>, OnDOMNodeEditComplete) const override;
|
virtual void replace_dom_node_attribute(DevTools::TabDescription const&, Web::UniqueNodeID, String, Vector<Attribute>, OnDOMNodeEditComplete) const override;
|
||||||
virtual void evaluate_javascript(DevTools::TabDescription const&, String, OnScriptEvaluationComplete) const override;
|
virtual void evaluate_javascript(DevTools::TabDescription const&, String, OnScriptEvaluationComplete) const override;
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue