mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use LayoutState::UsedValues::containing_block_used_values() more

Browse source 
Use this cached pointer to the containing block's used values when
obviously possible. This avoids a hash lookup each time, and these
hash lookups do show up in profiles.
This commit is contained in:
Andreas Kling 2024-09-13 14:47:39 +02:00 • committed by Andreas Kling
commit bdb67d2bcb
Notes: github-actions[bot] 2024-09-13 14:00:05 +00:00
3 changed files with 15 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -1670,64 +1670,57 @@ CSSPixels FormattingContext::calculate_inner_height(Layout::Box const& box, Avai
CSSPixels FormattingContext::containing_block_width_for(NodeWithStyleAndBoxModelMetrics const& node) const
{
auto const& containing_block_state = m_state.get(*node.containing_block());
auto const& node_state = m_state.get(node);
switch (node_state.width_constraint) {
auto const& used_values = m_state.get(node);
switch (used_values.width_constraint) {
case SizeConstraint::MinContent:
return 0;
case SizeConstraint::MaxContent:
return CSSPixels::max();
case SizeConstraint::None:
return containing_block_state.content_width();
return used_values.containing_block_used_values()->content_width();
}
VERIFY_NOT_REACHED();
}
CSSPixels FormattingContext::containing_block_height_for(NodeWithStyleAndBoxModelMetrics const& node) const
{
auto const& containing_block_state = m_state.get(*node.containing_block());
auto const& node_state = m_state.get(node);
auto const& used_values = m_state.get(node);
switch (node_state.height_constraint) {
switch (used_values.height_constraint) {
case SizeConstraint::MinContent:
return 0;
case SizeConstraint::MaxContent:
return CSSPixels::max();
case SizeConstraint::None:
return containing_block_state.content_height();
return used_values.containing_block_used_values()->content_height();
}
VERIFY_NOT_REACHED();
}
AvailableSize FormattingContext::containing_block_width_as_available_size(NodeWithStyleAndBoxModelMetrics const& node) const
{
auto const& containing_block_state = m_state.get(*node.containing_block());
auto const& node_state = m_state.get(node);
switch (node_state.width_constraint) {
auto const& used_values = m_state.get(node);
switch (used_values.width_constraint) {
case SizeConstraint::MinContent:
return AvailableSize::make_min_content();
case SizeConstraint::MaxContent:
return AvailableSize::make_max_content();
case SizeConstraint::None:
return AvailableSize::make_definite(containing_block_state.content_width());
return AvailableSize::make_definite(used_values.containing_block_used_values()->content_width());
}
VERIFY_NOT_REACHED();
}
AvailableSize FormattingContext::containing_block_height_as_available_size(NodeWithStyleAndBoxModelMetrics const& node) const
{
auto const& containing_block_state = m_state.get(*node.containing_block());
auto const& node_state = m_state.get(node);
switch (node_state.height_constraint) {
auto const& used_values = m_state.get(node);
switch (used_values.height_constraint) {
case SizeConstraint::MinContent:
return AvailableSize::make_min_content();
case SizeConstraint::MaxContent:
return AvailableSize::make_max_content();
case SizeConstraint::None:
return AvailableSize::make_definite(containing_block_state.content_height());
return AvailableSize::make_definite(used_values.containing_block_used_values()->content_height());
}
VERIFY_NOT_REACHED();
}