From bedb626c29913f4e355dfd50c29194e15ed71561 Mon Sep 17 00:00:00 2001 From: Jamie Mansfield Date: Sun, 4 Aug 2024 19:06:07 +0100 Subject: [PATCH] LibWeb: Set script force async to false when async changes --- Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt | 1 + Tests/LibWeb/Text/input/HTML/script-async-attribute.html | 4 ++++ Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt b/Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt index 50e1116c4a2..4b6a624b8aa 100644 --- a/Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt +++ b/Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt @@ -1,2 +1,3 @@ includeScript.async = false script.async = true +script.async = false diff --git a/Tests/LibWeb/Text/input/HTML/script-async-attribute.html b/Tests/LibWeb/Text/input/HTML/script-async-attribute.html index 897291dfc0b..dec5839cafe 100644 --- a/Tests/LibWeb/Text/input/HTML/script-async-attribute.html +++ b/Tests/LibWeb/Text/input/HTML/script-async-attribute.html @@ -7,5 +7,9 @@ const script = document.createElement("script"); println(`script.async = ${script.async}`); + + script.setAttribute("async", "true"); + script.removeAttribute("async"); + println(`script.async = ${script.async}`); }); diff --git a/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp index 4c812342684..a6de0683fe0 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp +++ b/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp @@ -66,6 +66,10 @@ void HTMLScriptElement::attribute_changed(FlyString const& name, Optional