mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-27 12:46:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Everywhere: Write dtors for types with incomplete members out-of-line

Browse source 
These are rejected by Clang (19) trunk as a result of
https://github.com/llvm/llvm-project/pull/77753.
This commit is contained in:
Daniel Bertalan 2024-06-16 10:38:35 +02:00 • committed by Tim Flynn
commit bf1f631f25
Notes: sideshowbarker 2024-07-16 23:34:49 +09:00
26 changed files with 42 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/NetworkJob.cpp
View file

@ -16,6 +16,8 @@ NetworkJob::NetworkJob(Stream& output_stream)
{
}
NetworkJob::~NetworkJob() = default;
void NetworkJob::did_finish(NonnullRefPtr<NetworkResponse>&& response)
{
if (is_cancelled())

2
Userland/Libraries/LibCore/NetworkJob.h
View file

@ -25,7 +25,7 @@ public:
ProtocolFailed,
Cancelled,
};
virtual ~NetworkJob() override = default;
virtual ~NetworkJob() override;
// Could fire twice, after Headers and after Trailers!
Function<void(HTTP::HeaderMap const& response_headers, Optional<u32> response_code)> on_headers_received;