mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-04 23:30:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement partial layout tree updates

Browse source 
DOM nodes now have two additional flags:

- Needs layout tree update
- Child needs layout tree update

These work similarly to the needs-style-update flags, but instead signal
the need to rebuild the corresponding part of the layout tree.

When a specific DOM node needs a layout tree update, we try to create
a new subtree starting at that node, and then replace the subtree in the
old layout tree with the newly created subtree.

This required some refactoring in TreeBuilder so that we can skip over
entire subtrees during a tree update.

Note that no partial updates happen yet (as of this commit) since we
always invalidate the full layout tree still. That will change in the
next commit.
This commit is contained in:
Andreas Kling 2025-01-13 12:23:40 +01:00 • committed by Andreas Kling
commit c01d810e5a
Notes: github-actions[bot] 2025-01-18 20:02:07 +00:00
6 changed files with 152 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/DOM/Document.cpp
View file

@ -1009,6 +1009,7 @@ void Document::tear_down_layout_tree()
{
m_layout_root = nullptr;
m_paintable = nullptr;
m_needs_full_layout_tree_update = true;
}
Color Document::background_color() const
@ -1218,7 +1219,7 @@ void Document::update_layout()
auto* document_element = this->document_element();
auto viewport_rect = navigable->viewport_rect();
if (!m_layout_root) {
if (!m_layout_root || needs_layout_tree_update() || child_needs_layout_tree_update() || needs_full_layout_tree_update()) {
Layout::TreeBuilder tree_builder;
m_layout_root = verify_cast<Layout::Viewport>(*tree_builder.build(*this));
@ -1226,6 +1227,8 @@ void Document::update_layout()
propagate_overflow_to_viewport(*document_element, *m_layout_root);
propagate_scrollbar_width_to_viewport(*document_element, *m_layout_root);
}
set_needs_full_layout_tree_update(false);
}
// Assign each box that establishes a formatting context a list of absolutely positioned children it should take care of during layout