mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Use CallBuiltin for Math.sin()

Browse source 
Improves performance on https://pierre.co/
This commit is contained in:
Aliaksandr Kalenik 2025-05-26 13:54:46 +03:00 • committed by Jelle Raaijmakers
commit c02535e9f9
Notes: github-actions[bot] 2025-05-26 19:53:53 +00:00
4 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Bytecode/Builtins.h
View file

@ -22,7 +22,8 @@ namespace JS::Bytecode {
O(MathImul, math_imul, Math, imul, 2) \
O(MathRandom, math_random, Math, random, 0) \
O(MathRound, math_round, Math, round, 1) \
O(MathSqrt, math_sqrt, Math, sqrt, 1)
O(MathSqrt, math_sqrt, Math, sqrt, 1) \
O(MathSin, math_sin, Math, sin, 1)
enum class Builtin : u8 {
#define DEFINE_BUILTIN_ENUM(name, ...) name,

2
Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -2819,6 +2819,8 @@ static ThrowCompletionOr<Value> dispatch_builtin_call(Bytecode::Interpreter& int
return TRY(MathObject::round_impl(interpreter.vm(), interpreter.get(arguments[0])));
case Builtin::MathSqrt:
return TRY(MathObject::sqrt_impl(interpreter.vm(), interpreter.get(arguments[0])));
case Builtin::MathSin:
return TRY(MathObject::sin_impl(interpreter.vm(), interpreter.get(arguments[0])));
case Bytecode::Builtin::__Count:
VERIFY_NOT_REACHED();
}

11
Libraries/LibJS/Runtime/MathObject.cpp
View file

@ -42,7 +42,7 @@ void MathObject::initialize(Realm& realm)
define_native_function(realm, vm.names.max, max, 2, attr);
define_native_function(realm, vm.names.min, min, 2, attr);
define_native_function(realm, vm.names.trunc, trunc, 1, attr);
define_native_function(realm, vm.names.sin, sin, 1, attr);
define_native_function(realm, vm.names.sin, sin, 1, attr, Bytecode::Builtin::MathSin);
define_native_function(realm, vm.names.cos, cos, 1, attr);
define_native_function(realm, vm.names.tan, tan, 1, attr);
define_native_function(realm, vm.names.pow, pow, 2, attr, Bytecode::Builtin::MathPow);
@ -905,10 +905,10 @@ JS_DEFINE_NATIVE_FUNCTION(MathObject::sign)
}
// 21.3.2.31 Math.sin ( x ), https://tc39.es/ecma262/#sec-math.sin
JS_DEFINE_NATIVE_FUNCTION(MathObject::sin)
ThrowCompletionOr<Value> MathObject::sin_impl(VM& vm, Value value)
{
// 1. Let n be ? ToNumber(x).
auto number = TRY(vm.argument(0).to_number(vm));
auto number = TRY(value.to_number(vm));
// 2. If n is NaN, n is +0𝔽, or n is -0𝔽, return n.
if (number.is_nan() || number.is_positive_zero() || number.is_negative_zero())
@ -922,6 +922,11 @@ JS_DEFINE_NATIVE_FUNCTION(MathObject::sin)
return Value(::sin(number.as_double()));
}
JS_DEFINE_NATIVE_FUNCTION(MathObject::sin)
{
return sin_impl(vm, vm.argument(0));
}
// 21.3.2.32 Math.sinh ( x ), https://tc39.es/ecma262/#sec-math.sinh
JS_DEFINE_NATIVE_FUNCTION(MathObject::sinh)
{

2
Libraries/LibJS/Runtime/MathObject.h
View file

@ -28,6 +28,8 @@ public:
static ThrowCompletionOr<Value> abs_impl(VM&, Value);
static ThrowCompletionOr<Value> sum_precise_impl(VM&, Value);
static ThrowCompletionOr<Value> imul_impl(VM&, Value, Value);
static ThrowCompletionOr<Value> sin_impl(VM&, Value);
static Value random_impl();
private: