mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-21 00:38:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

LibWeb: Store stop-opacity in computed form in ComputedProperties

Browse source
This commit is contained in:
Callum Law 2025-09-08 00:13:13 +12:00 • committed by Tim Ledbetter
commit c045969234
Notes: github-actions[bot] 2025-09-08 10:06:57 +00:00
3 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/CSS/CSSStyleProperties.cpp
View file

@ -813,10 +813,6 @@ RefPtr<StyleValue const> CSSStyleProperties::style_value_for_computed_property(L
return get_computed_value(property_id);
}
case PropertyID::StopOpacity: {
auto opacity = layout_node.computed_values().stop_opacity();
return NumberStyleValue::create(opacity);
}
case PropertyID::StrokeOpacity: {
auto opacity = layout_node.computed_values().stroke_opacity();
return NumberStyleValue::create(opacity);

3
Libraries/LibWeb/CSS/ComputedProperties.cpp
View file

@ -515,8 +515,7 @@ float ComputedProperties::stroke_opacity() const
float ComputedProperties::stop_opacity() const
{
auto const& value = property(PropertyID::StopOpacity);
return resolve_opacity_value(value);
return property(PropertyID::StopOpacity).as_number().number();
}
FillRule ComputedProperties::fill_rule() const

1
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -3285,6 +3285,7 @@ NonnullRefPtr<StyleValue const> StyleComputer::compute_value_of_property(Propert
return compute_border_or_outline_width(specified_value, get_property_specified_value(PropertyID::OutlineStyle), computation_context);
case PropertyID::FillOpacity:
case PropertyID::Opacity:
case PropertyID::StopOpacity:
return compute_opacity(specified_value, computation_context);
default:
// FIXME: We should replace this with a VERIFY_NOT_REACHED() once all properties have their own handling.