mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-12 04:22:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Always log debug message about failure to parse CSS fonts

Browse source 
It's always good to know when and why a CSS font fails to parse,
so that we can file issues about missing functionality.
This commit is contained in:
Andreas Kling 2024-04-07 19:15:23 +02:00
commit c0ea8825b5
Notes: sideshowbarker 2024-07-16 22:11:09 +09:00
1 changed files with 13 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -119,8 +119,11 @@ public:
virtual void resource_did_load() override virtual void resource_did_load() override
{ {
auto result = try_load_font(); auto result = try_load_font();
if (result.is_error()) if (result.is_error()) {
return start_loading_next_url(); dbgln("Failed to parse font: {}", result.error());
start_loading_next_url();
return;
}
m_vector_font = result.release_value(); m_vector_font = result.release_value();
m_style_computer.did_load_font(m_family_name); m_style_computer.did_load_font(m_family_name);
} }
@ -160,19 +163,15 @@ private:
ErrorOr<NonnullRefPtr<Gfx::VectorFont>> try_load_font() ErrorOr<NonnullRefPtr<Gfx::VectorFont>> try_load_font()
{ {
// FIXME: This could maybe use the format() provided in @font-face as well, since often the mime type is just application/octet-stream and we have to try every format // FIXME: This could maybe use the format() provided in @font-face as well, since often the mime type is just application/octet-stream and we have to try every format
auto mime_type = resource()->mime_type(); auto const& mime_type = resource()->mime_type();
if (mime_type == "font/ttf"sv || mime_type == "application/x-font-ttf"sv) if (mime_type == "font/ttf"sv || mime_type == "application/x-font-ttf"sv)
return TRY(OpenType::Font::try_load_from_externally_owned_memory(resource()->encoded_data())); return OpenType::Font::try_load_from_externally_owned_memory(resource()->encoded_data());
if (mime_type == "font/woff"sv || mime_type == "application/font-woff"sv) if (mime_type == "font/woff"sv || mime_type == "application/font-woff"sv)
return TRY(WOFF::Font::try_load_from_externally_owned_memory(resource()->encoded_data())); return WOFF::Font::try_load_from_externally_owned_memory(resource()->encoded_data());
if (mime_type == "font/woff2"sv || mime_type == "application/font-woff2"sv) { if (mime_type == "font/woff2"sv || mime_type == "application/font-woff2"sv)
auto woff2 = WOFF2::Font::try_load_from_externally_owned_memory(resource()->encoded_data()); return WOFF2::Font::try_load_from_externally_owned_memory(resource()->encoded_data());
if (woff2.is_error()) {
dbgln("WOFF2 error: {}", woff2.error()); // We don't have the luxury of knowing the MIME type, so we have to try all formats.
return woff2.release_error();
}
return woff2.release_value();
}
auto ttf = OpenType::Font::try_load_from_externally_owned_memory(resource()->encoded_data()); auto ttf = OpenType::Font::try_load_from_externally_owned_memory(resource()->encoded_data());
if (!ttf.is_error()) if (!ttf.is_error())
return ttf.release_value(); return ttf.release_value();
@ -182,7 +181,7 @@ private:
auto woff2 = WOFF2::Font::try_load_from_externally_owned_memory(resource()->encoded_data()); auto woff2 = WOFF2::Font::try_load_from_externally_owned_memory(resource()->encoded_data());
if (!woff2.is_error()) if (!woff2.is_error())
return woff2.release_value(); return woff2.release_value();
return woff2.release_error(); return Error::from_string_literal("Automatic format detection failed");
} }
StyleComputer& m_style_computer; StyleComputer& m_style_computer;