LibJS/Bytecode: Don't reparse regular expressions on instantiation

The RegExpLiteral AST node already has the parsed regex::Parser::Result so let's plumb that over to the bytecode executable instead of reparsing the regex every time NewRegExp is executed. ~12% speed-up on language/literals/regexp/S7.8.5_A2.1_T2.js in test262.
Author: https://github.com/awesomekling Commit: c0f985ffcf Pull-request: https://github.com/SerenityOS/serenity/pull/19992 Reviewed-by: https://github.com/Hendiadyoin1 Reviewed-by: https://github.com/trflynn89
2025-04-26 22:38:51 +00:00 · 2023-07-13 10:49:07 +02:00 · 2023-07-13 10:49:07 +02:00 · c0f985ffcf · 2024-07-16 22:11:09 +09:00
commit c0f985ffcf
parent a098f38cab
9 changed files with 109 additions and 4 deletions
--- a/Userland/Libraries/LibJS/Bytecode/RegexTable.cpp
+++ b/Userland/Libraries/LibJS/Bytecode/RegexTable.cpp
@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include <LibJS/Bytecode/RegexTable.h>
+
+namespace JS::Bytecode {
+
+RegexTableIndex RegexTable::insert(ParsedRegex regex)
+{
+    m_regexes.append(move(regex));
+    return m_regexes.size() - 1;
+}
+
+ParsedRegex const& RegexTable::get(RegexTableIndex index) const
+{
+    return m_regexes[index.value()];
+}
+
+void RegexTable::dump() const
+{
+    outln("Regex Table:");
+    for (size_t i = 0; i < m_regexes.size(); i++)
+        outln("{}: {}", i, m_regexes[i].pattern);
+}
+
+}