mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Support counter-* properties on pseudo-elements

Browse source 
There are multiple things happening here which are interconnected:

- We now use AbstractElement to refer to the source of a counter, which
  means we also need to pass that around to compute `content`.

- Give AbstractElement new helper methods that are needed by
  CountersSet, so it doesn't have to care whether it's dealing with a
  true Element or PseudoElement.

- The CountersSet algorithms now walk the layout tree instead of DOM
  tree, so TreeBuilder needs to wait until the layout node exists
  before it resolves counters for it.

- Resolve counters when creating a pseudo-element's layout node. We
  awkwardly compute the `content` value up to twice: Once to figure out
  what kind of node we need to make, and then if it's a string, we do
  so again after counters are resolved so we can get the true value of
  any `counter()` functions. This will need adjusting in the future but
  it works for now.
This commit is contained in:
Sam Atkins 2025-06-17 16:33:23 +01:00
commit c1d4323cf7
Notes: github-actions[bot] 2025-06-19 11:36:57 +00:00
14 changed files with 247 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/CSS/CountersSet.h
View file

@ -9,6 +9,7 @@
#include <AK/Checked.h>
#include <AK/FlyString.h>
#include <AK/Optional.h>
#include <LibWeb/DOM/AbstractElement.h>
#include <LibWeb/Forward.h>
namespace Web::CSS {
@ -22,7 +23,7 @@ using CounterValue = Checked<i32>;
// https://drafts.csswg.org/css-lists-3/#counter
struct Counter {
FlyString name;
UniqueNodeID originating_element_id; // "creator"
DOM::AbstractElement originating_element; // "creator"
bool reversed { false };
Optional<CounterValue> value;
};
@ -33,17 +34,21 @@ public:
CountersSet() = default;
~CountersSet() = default;
Counter& instantiate_a_counter(FlyString name, UniqueNodeID originating_element_id, bool reversed, Optional<CounterValue>);
void set_a_counter(FlyString name, UniqueNodeID originating_element_id, CounterValue value);
void increment_a_counter(FlyString name, UniqueNodeID originating_element_id, CounterValue amount);
Counter& instantiate_a_counter(FlyString name, DOM::AbstractElement const&, bool reversed, Optional<CounterValue>);
void set_a_counter(FlyString name, DOM::AbstractElement const&, CounterValue value);
void increment_a_counter(FlyString name, DOM::AbstractElement const&, CounterValue amount);
void append_copy(Counter const&);
Optional<Counter&> last_counter_with_name(FlyString const& name);
Optional<Counter&> counter_with_same_name_and_creator(FlyString const& name, UniqueNodeID originating_element_id);
Optional<Counter&> counter_with_same_name_and_creator(FlyString const& name, DOM::AbstractElement const&);
Vector<Counter> const& counters() const { return m_counters; }
bool is_empty() const { return m_counters.is_empty(); }
void visit_edges(GC::Cell::Visitor&);
String dump() const;
private:
Vector<Counter> m_counters;
};