mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-09 11:06:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Meta: Clean up flatpak manifest and remove most linter warnings
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Build Dev Container Image / build (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
We now clean up installed helper tools, includes from dependencies, and
pkgconfig/CMake files. This decreases the size of the flatpak from
~206MiB to ~150 MiB on my machine.

The manifest is also mostly clean of linter warnings from the
flatpack-builder manifest linter, with the exception of the overly broad
session bus policy.

The docs at https://docs.flathub.org/docs/for-app-authors/linter list a
method for selecting the correct session bus policies, but it is unclear
how to actually get the full set.
This commit is contained in:
Andrew Kaster 2025-07-11 13:06:08 -06:00 • committed by Andrew Kaster
commit c1ece2b4ed
Notes: github-actions[bot] 2025-07-15 20:18:08 +00:00
1 changed files with 35 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

38
Meta/CMake/flatpak/org.ladybird.Ladybird.json
View file

@ -13,6 +13,17 @@
"--socket=pulseaudio", "--socket=pulseaudio",
"--socket=session-bus" "--socket=session-bus"
], ],
"cleanup": [
"/sbin",
"*.a",
"/lib/cmake",
"/lib/pkgconfig",
"/include",
"/share/aclocal",
"/share/cmake",
"/share/doc",
"/share/man"
],
"modules": [ "modules": [
{ {
"name": "simdutf", "name": "simdutf",
@ -66,6 +77,9 @@
"-DSKIP_INSTALL_EXECUTABLES=ON", "-DSKIP_INSTALL_EXECUTABLES=ON",
"-DSKIP_INSTALL_FILES=OFF", "-DSKIP_INSTALL_FILES=OFF",
"-DSKIP_INSTALL_PROGRAMS=ON" "-DSKIP_INSTALL_PROGRAMS=ON"
],
"cleanup": [
"/bin"
] ]
}, },
{ {
@ -123,6 +137,12 @@
"--disable-debug", "--disable-debug",
"--enable-release", "--enable-release",
"--enable-shared" "--enable-shared"
],
"cleanup": [
"/bin",
"/lib/icu",
"/lib/libicutu.so*",
"/share/icu"
] ]
}, },
{ {
@ -168,11 +188,14 @@
"-DLIBXML2_WITH_ICU=ON", "-DLIBXML2_WITH_ICU=ON",
"-DLIBXML2_WITH_LZMA=ON", "-DLIBXML2_WITH_LZMA=ON",
"-DLIBXML2_WITH_ZLIB=ON" "-DLIBXML2_WITH_ZLIB=ON"
],
"cleanup": [
"/bin"
] ]
}, },
{ {
"name": "vulkan-memory-allocator", "name": "vulkan-memory-allocator",
"buildsystem": "cmake", "buildsystem": "cmake-ninja",
"sources": [ "sources": [
{ {
"type": "git", "type": "git",
@ -202,7 +225,8 @@
], ],
"build-commands": [ "build-commands": [
"./gn-whole-enchilada.sh" "./gn-whole-enchilada.sh"
] ],
"cleanup": [ "*" ]
}, },
{ {
"name": "brotli", "name": "brotli",
@ -220,6 +244,9 @@
"-DCMAKE_INSTALL_LIBDIR=lib", "-DCMAKE_INSTALL_LIBDIR=lib",
"-DBROTLI_DISABLE_TESTS=ON", "-DBROTLI_DISABLE_TESTS=ON",
"-DBROTLI_BUILD_TOOLS=OFF" "-DBROTLI_BUILD_TOOLS=OFF"
],
"cleanup": [
"/bin"
] ]
}, },
{ {
@ -274,7 +301,7 @@
"-DCMAKE_PREFIX_PATH=/app" "-DCMAKE_PREFIX_PATH=/app"
], ],
"cleanup": [ "cleanup": [
"/app/bin" "/bin"
] ]
}, },
{ {
@ -323,6 +350,9 @@
"-DWEBP_BUILD_DWEBP=OFF", "-DWEBP_BUILD_DWEBP=OFF",
"-DWEBP_BUILD_WEBPMUX=OFF", "-DWEBP_BUILD_WEBPMUX=OFF",
"-DWEBP_BUILD_EXTRAS=OFF" "-DWEBP_BUILD_EXTRAS=OFF"
],
"cleanup": [
"/share/WebP"
] ]
}, },
{ {
@ -476,6 +506,8 @@
"-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_BUILD_TYPE=Release",
"-DENABLE_LTO_FOR_RELEASE=OFF", "-DENABLE_LTO_FOR_RELEASE=OFF",
"-DENABLE_INSTALL_FREEDESKTOP_FILES=ON", "-DENABLE_INSTALL_FREEDESKTOP_FILES=ON",
"-DENABLE_INSTALL_HEADERS=OFF",
"-DBUILD_TESTING=OFF",
"-DICU_ROOT=/app" "-DICU_ROOT=/app"
] ]
} }