mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Meta+CI: Enforce python linting with ruff
Some checks are pending
CI / macOS, arm64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
We could use flake8 for linting, but ruff is compatible with black
formatting out-of-the-box. It also seems to catch more than flake8,
such as unnecessary f-strings.
This commit is contained in:
Timothy Flynn 2025-06-09 09:32:47 -04:00 • committed by Tim Flynn
commit c204149bbd
Notes: github-actions[bot] 2025-06-09 15:26:24 +00:00
3 changed files with 24 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Meta/lint-python.sh
View file

@ -5,11 +5,11 @@ set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1
check_argument="--check"
overwrite=0
if [ "$#" -gt "0" ]; then
if [ "--overwrite-inplace" = "$1" ] ; then
check_argument=""
overwrite=1
shift
fi
fi
@ -31,12 +31,18 @@ else
fi
if (( ${#files[@]} )); then
if ! command -v black >/dev/null 2>&1 ; then
echo "black is not available, but python files need linting! Either skip this script, or install black."
if ! command -v ruff >/dev/null 2>&1 ; then
echo "Please install ruff: pip3 install ruff"
exit 1
fi
black ${check_argument} "${files[@]}"
if [[ ${overwrite} -eq 0 ]] ; then
ruff check "${files[@]}"
ruff format --check "${files[@]}"
else
ruff check --fix "${files[@]}"
ruff format "${files[@]}"
fi
else
echo "No py files to check."
fi