mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 03:55:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Let HTMLScriptElement call Document::run_javascript()

Browse source 
The fewer places we invoke the JS parser the better. Unless we have
some specific reason to parse manually, we can just call Document.
This commit is contained in:
Andreas Kling 2020-06-23 16:42:38 +02:00
parent 3a5af6ef61
commit c24f5585b2
Notes: sideshowbarker 2024-07-19 05:25:43 +09:00
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/DOM/Document.cpp
View file

@ -412,8 +412,6 @@ JS::Value Document::run_javascript(const StringView& source)
parser.print_errors();
return JS::js_undefined();
}
dbg() << "Document::run_javascript('" << source << "') will run:";
program->dump(0);
return document().interpreter().run(document().interpreter().global_object(), *program);
}

8
Libraries/LibWeb/DOM/HTMLScriptElement.cpp
View file

@ -55,13 +55,7 @@ void HTMLScriptElement::set_non_blocking(Badge<HTMLDocumentParser>, bool non_blo
void HTMLScriptElement::execute_script()
{
auto parser = JS::Parser(JS::Lexer(m_script_source));
auto program = parser.parse_program();
if (parser.has_errors()) {
parser.print_errors();
return;
}
document().interpreter().run(document().interpreter().global_object(), *program);
document().run_javascript(m_script_source);
}
void HTMLScriptElement::prepare_script(Badge<HTMLDocumentParser>)