mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 17:19:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Don't directly teach the heap about the javascript VM or Realm

Browse source 
Instead, smuggle it in as a `void*` private data and let Javascript
aware code cast out that pointer to a VM&.

In order to make this split, rename JS::Cell to JS::CellImpl. Once we
have a LibGC, this will become GC::Cell. CellImpl then has no specific
knowledge of the VM& and Realm&. That knowledge is instead put into
JS::Cell, which inherits from CellImpl. JS::Cell is responsible for
JavaScript's realm initialization, as well as converting of the void*
private data to what it knows should be the VM&.
This commit is contained in:
Shannon Booth 2024-11-14 20:22:33 +13:00 • committed by Andreas Kling
commit c2988a7dd5
Notes: github-actions[bot] 2024-11-14 14:39:37 +00:00
27 changed files with 346 additions and 296 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibJS/Runtime/Value.h
View file

@ -19,6 +19,7 @@
#include <AK/String.h>
#include <AK/Types.h>
#include <LibJS/Forward.h>
#include <LibJS/Heap/Cell.h>
#include <LibJS/Heap/GCPtr.h>
#include <LibJS/Heap/Handle.h>
#include <LibJS/Heap/NanBoxedValue.h>
@ -256,6 +257,18 @@ public:
{
}
Cell& as_cell()
{
VERIFY(is_cell());
return *extract_pointer<Cell>();
}
Cell& as_cell() const
{
VERIFY(is_cell());
return *extract_pointer<Cell>();
}
double as_double() const
{
VERIFY(is_number());
@ -661,14 +674,14 @@ private:
{
}
explicit Handle(Value value, Cell* cell, SourceLocation location)
explicit Handle(Value value, CellImpl* cell, SourceLocation location)
: m_value(value)
, m_handle(Handle<Cell>::create(cell, location))
, m_handle(Handle<CellImpl>::create(cell, location))
{
}
Optional<Value> m_value;
Handle<Cell> m_handle;
Handle<CellImpl> m_handle;
};
inline Handle<Value> make_handle(Value value, SourceLocation location = SourceLocation::current())